Skip to content

Updated link to Event Listeners page #10195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2018
Merged

Updated link to Event Listeners page #10195

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f521534
Updated link to Event Listeners page
ThomasLandauer Aug 16, 2018
567616f
Changing to absolute url, as requested
ThomasLandauer Aug 16, 2018
58647a0
fix the markup
xabbuh Aug 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions doctrine/event_listeners_subscribers.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,9 @@ entity), you should check for the entity's class type in your method
.. tip::

In Doctrine 2.4, a feature called Entity Listeners was introduced.
It is a lifecycle listener class used for an entity. You can read
about it in `the Doctrine Documentation`_.
It is a lifecycle listener class used for an entity. See
:doc:`Entity Listeners </entity-listeners>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the documentation for DoctrineBundle is built independently we cannot use the doc role here. I would revert the changes in this paragraph...



Creating the Subscriber Class
-----------------------------
Expand Down Expand Up @@ -269,4 +270,3 @@ to the tag like so:
definitions which are described :doc:`in their own article </service_container/lazy_services>`

.. _`The Event System`: http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/events.html
.. _`the Doctrine Documentation`: http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/events.html#entity-listeners
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and just change the target here to https://symfony.com/doc/current/bundles/DoctrineBundle/entity-listeners.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, done :-)