-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Specify version for symfony/skeleton #10141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
setup/flex.rst
Outdated
@@ -111,7 +111,7 @@ Symfony application by executing the following command: | |||
|
|||
.. code-block:: terminal | |||
|
|||
$ composer create-project symfony/skeleton my-project | |||
$ composer create-project symfony/skeleton my-project 4.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should use a constraint that will pick the latest patch release for 4.1 like this: composer create-project symfony/skeleton:^4.1 my-project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that was possible but I couldn't figure out how to achieve it.
That works so much better.
Instead of v4.1.0, you get v4.1.3.1
I've amended the PR to |
I understand your reasoning. And for older maintained documentation pages it makes sense (so I merged #10139). But maybe we should postpone the change here until Symfony 4.2 is out. This way people do have to type less to get the same result. What do you think? |
@xabbuh That makes sense. For some reason I keep thinking 4.2 is already out. |
Going forward, what do you think the process should be? e.g. 4.2 to 4.3 |
I am afraid we have to take that risk. We should maybe think about a meta issue that lists all the action we need to take when a new version is published. |
Let's close here because of the reasons given ... and we'll make this change in November 2018 when Symfony 4.2 is out. Thanks! |
otherwise latest version is downloaded