Specify version for symfony/skeleton #10139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Aug 3, 2018
setup/flex.rst
Outdated
| @@ -111,7 +111,7 @@ Symfony application by executing the following command: | |||
|
|
|||
| .. code-block:: terminal | |||
|
|
|||
| $ composer create-project symfony/skeleton my-project | |||
| $ composer create-project symfony/skeleton my-project 3.4 | |||
There was a problem hiding this comment.
IMO we should use a constraint that will pick the latest patch release for 3.4 like this: composer create-project symfony/skeleton:^3.4 my-project
otherwise latest version is downloaded
|
I've amended the PR to |
xabbuh
approved these changes
Aug 4, 2018
|
Thank you @hackzilla. |
xabbuh
added a commit
that referenced
this pull request
Aug 4, 2018
This PR was merged into the 3.4 branch. Discussion ---------- Specify version for symfony/skeleton otherwise latest version is downloaded Commits ------- 8be5310 Specify version for symfony/skeleton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise latest version is downloaded