Skip to content

Use a released version of doctrine/rst-parser #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Use a released version of doctrine/rst-parser #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"require": {
"ext-json": "*",
"ext-curl": "*",
"doctrine/rst-parser": "0.4.x-dev",
"doctrine/rst-parser": "^0.4",
Copy link
Contributor

@jrushlow jrushlow Apr 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be better todo >=0.4 so we dont have to do a version bump when they push out 0.5? i'm not sure of the over stability of rst-parser (even in dev).. just realized we're committing the .lock

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question!
If they push 0.5 we would like to review all the changes carefully before we use the new version.

Semver works differently before 1.0. Basically, minor versions can include BC breaks.

"scrivo/highlight.php": "^9.12.0",
"symfony/filesystem": "^5.2",
"symfony/finder": "^5.2",
Expand Down
19 changes: 9 additions & 10 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.