Use a released version of doctrine/rst-parser #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
approved these changes
Apr 16, 2021
javiereguiluz
approved these changes
Apr 16, 2021
jrushlow
reviewed
Apr 16, 2021
| @@ -16,7 +16,7 @@ | |||
| "require": { | |||
| "ext-json": "*", | |||
| "ext-curl": "*", | |||
| "doctrine/rst-parser": "0.4.x-dev", | |||
| "doctrine/rst-parser": "^0.4", | |||
There was a problem hiding this comment.
would it be better todo just realized we're committing the >=0.4 so we dont have to do a version bump when they push out 0.5? i'm not sure of the over stability of rst-parser (even in dev)...lock
There was a problem hiding this comment.
Good question!
If they push 0.5 we would like to review all the changes carefully before we use the new version.
Semver works differently before 1.0. Basically, minor versions can include BC breaks.
jrushlow
approved these changes
Apr 16, 2021
|
Thanks Tobias! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.