generate annotations in yml format #603
Conversation
|
I would prefer it to be |
|
the first |
|
Oh yeah. You are right, guess I must be subconsciously clicking XML without noticing :P in that case |
| @@ -427,7 +427,7 @@ and add some posts:: | |||
| } | |||
| } | |||
|
|
|||
| The | |||
| The | |||
There was a problem hiding this comment.
this seems like a very strange line...
There was a problem hiding this comment.
indeed. just saw it cut the trailing blank, but it looks like a whole paragraph was lost during some editing here... would need to look at blame i guess or the history of this file to figure it out. can do tonight.
There was a problem hiding this comment.
this was already broken in the original commit: 6f21e4b - i tracked further back and did not find where the The appeared. just dropping it.
|
Annotations would use As the best practice is using that, I'm leaning a bit towards using it aswell. On the other hand, I'll do a walkthrough to be consistent with the best practices after Sf2.6 is released. |
dbu
force-pushed
the
generate-best-practice
branch
from
0a7ffb6 to
2bf785f
Compare
|
okay, updated |
|
ping @wouterj |
|
This should be merged into 1.1, I believe? (we should create a plan about when to deprecate versions) |
|
agreed. i can merge on cli if you want |
|
if its all good, that is |
|
Thanks David. |
This PR was submitted for the master branch but it was merged into the 1.1 branch instead (closes #603). Discussion ---------- generate annotations in yml format replaces #568 i went with yml rather than annotations. what would annotations do, service definitions by annotations? Commits ------- 9cf0231 generate annotations in yml format. fix #568
replaces #568
i went with yml rather than annotations. what would annotations do, service definitions by annotations?