Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Generate with no interaction -> xml #568

Closed
wants to merge 1 commit into from
Closed

Generate with no interaction -> xml #568

wants to merge 1 commit into from

Conversation

SimonVanherweghe
Copy link
Contributor

This is a small issue, almost nagging
When you generate the bundle without interaction, the services and routing files in the bundle are in xml format.
Strange because the YAML version is always first in the row. Confusing.
I don't think there is an option to specify YAML format, is it?
So I went for generating the bundle with interaction

This is a small issue, almost nagging
When you generate the bundle without interaction, the services and routing files in the bundle are in xml format.
Strange because the YAML version is always first in the row. Confusing.
I don't think there is an option to specify YAML format, is it?
So I went for generating the bundle with interaction
@dbu
Copy link
Member

dbu commented Sep 21, 2014

@dantleech do you have an opinion here. i guess the change by simon makes sense if there is no parameter to make the command generate yml files without interaction.

@dantleech
Copy link
Member

You can specify the format with --format=xml

I would personally prefer that we add that option to the example, and explain that they can change that option as they want (for example by adding a .. note:: section.

I fear that if its interactive then people will be "creative" and things won't work.

@dbu
Copy link
Member

dbu commented Sep 22, 2014

oh, good. then lets add --format=yml (that was the idea, i think?) what
is the default tab on the examples afterwards? we could even provide the
line in all 3 formats with tabs :-)

@dbu
Copy link
Member

dbu commented Oct 20, 2014

@DoneBySimon did you try the --format=yml variant @dantleech proposed?

@lsmith77
Copy link
Member

ping

@dbu
Copy link
Member

dbu commented Nov 2, 2014

ping @DoneBySimon

@wouterj
Copy link
Member

wouterj commented Nov 2, 2014

The team that created the best practices used $ php app/console generate:bundle --namespace=AppBundle --dir=src --format=annotation --no-interaction. I think we can assume that's the correct command to use.

dbu added a commit that referenced this pull request Nov 3, 2014
@dbu
Copy link
Member

dbu commented Nov 3, 2014

continued in #603

dbu added a commit that referenced this pull request Jan 18, 2015
@dbu
Copy link
Member

dbu commented Jan 21, 2015

see #603

@dbu dbu closed this Jan 21, 2015
dbu added a commit that referenced this pull request Jan 21, 2015
wouterj added a commit that referenced this pull request Jan 21, 2015
This PR was submitted for the master branch but it was merged into the 1.1 branch instead (closes #603).

Discussion
----------

generate annotations in yml format

replaces #568

i went with yml rather than annotations. what would annotations do, service definitions by annotations?

Commits
-------

9cf0231 generate annotations in yml format. fix #568
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants