-
Notifications
You must be signed in to change notification settings - Fork 439
Build EditorExtension as part of CI job #2075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build EditorExtension as part of CI job #2075
Conversation
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple typos, otherwise LGTM. Nice to review these changes in Swift instead of Python.
SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/common/BuildCommand.swift
Outdated
Show resolved
Hide resolved
SwiftSyntaxDevUtils/Sources/swift-syntax-dev-utils/commands/Build.swift
Outdated
Show resolved
Hide resolved
e08212b
to
e29010c
Compare
@swift-ci please test |
@swift-ci Please test Windows |
e29010c
to
1833489
Compare
@swift-ci please test |
We should only build the editor extension on macOS because there’s no xcodebuild on Linux. |
1833489
to
733c5d3
Compare
Just fixed it. Triggering CI |
@swift-ci please test |
@swift-ci please test windows |
@swift-ci Please test Windows |
Resolves #2070