Skip to content

Build EditorExtension as part of CI job #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Aug 16, 2023

Resolves #2070

@kimdv kimdv requested a review from ahoppen as a code owner August 16, 2023 07:52
@kimdv
Copy link
Contributor Author

kimdv commented Aug 16, 2023

@swift-ci please test

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple typos, otherwise LGTM. Nice to review these changes in Swift instead of Python.

@kimdv kimdv force-pushed the kimdv/2070-build-swiftrefactorextensionxcodeproj-in-ci branch from e08212b to e29010c Compare August 16, 2023 17:49
@kimdv
Copy link
Contributor Author

kimdv commented Aug 16, 2023

@swift-ci please test

@ahoppen
Copy link
Member

ahoppen commented Aug 16, 2023

@swift-ci Please test Windows

@kimdv kimdv force-pushed the kimdv/2070-build-swiftrefactorextensionxcodeproj-in-ci branch from e29010c to 1833489 Compare August 17, 2023 06:44
@kimdv
Copy link
Contributor Author

kimdv commented Aug 17, 2023

@swift-ci please test

@ahoppen
Copy link
Member

ahoppen commented Aug 17, 2023

We should only build the editor extension on macOS because there’s no xcodebuild on Linux.

@kimdv kimdv force-pushed the kimdv/2070-build-swiftrefactorextensionxcodeproj-in-ci branch from 1833489 to 733c5d3 Compare August 17, 2023 15:42
@kimdv
Copy link
Contributor Author

kimdv commented Aug 17, 2023

We should only build the editor extension on macOS because there’s no xcodebuild on Linux.

Just fixed it. Triggering CI

@kimdv
Copy link
Contributor Author

kimdv commented Aug 17, 2023

@swift-ci please test

@kimdv
Copy link
Contributor Author

kimdv commented Aug 17, 2023

@swift-ci please test windows

@ahoppen
Copy link
Member

ahoppen commented Aug 17, 2023

@swift-ci Please test Windows

@kimdv kimdv merged commit 6f23c24 into swiftlang:main Aug 17, 2023
@kimdv kimdv deleted the kimdv/2070-build-swiftrefactorextensionxcodeproj-in-ci branch August 17, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build SwiftRefactorExtension.xcodeproj in CI
2 participants