Skip to content

[5.9] Support parsing of borrowing get #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2023
Merged

[5.9] Support parsing of borrowing get #1907

merged 1 commit into from
Jul 14, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 14, 2023

  • Explanation: The new parser didn’t accept borrowing get while the C++ parser did
  • Scope: Parsing of modifiers in front of accessors
  • Risk: Low, very targeted change
  • Testing: Added new test case
  • Issue: rdar://112168704
  • Reviewer: @bnbarham and @rintaro on Support parsing of borrowing get #1904

@ahoppen
Copy link
Member Author

ahoppen commented Jul 14, 2023

@swift-ci Please test

@ahoppen ahoppen requested a review from bnbarham July 14, 2023 06:32
@ahoppen ahoppen changed the title Support parsing of borrowing get [5.9] Support parsing of borrowing get Jul 14, 2023
@ahoppen ahoppen merged commit 5c6cde3 into swiftlang:release/5.9 Jul 14, 2023
@ahoppen ahoppen deleted the ahoppen/5.9/borrowing-getter branch July 14, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @bnbarham