Skip to content

Support parsing of borrowing get #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2023
Merged

Support parsing of borrowing get #1904

merged 1 commit into from
Jul 14, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 13, 2023

rdar://112168704

@ahoppen ahoppen requested a review from bnbarham July 13, 2023 10:56
@ahoppen
Copy link
Member Author

ahoppen commented Jul 13, 2023

@swift-ci Please test

bnbarham
bnbarham approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea when borrowing was added such that we missed it? I assume it was a while ago before code owners was updated?

@ahoppen
Copy link
Member Author

ahoppen commented Jul 14, 2023

Yes, swiftlang/swift#63990 was merged on 3/1 and swiftlang/swift#64596, which modified the code owners, was merged on 3/24.

@ahoppen ahoppen merged commit d21d996 into swiftlang:main Jul 14, 2023
@ahoppen ahoppen deleted the ahoppen/borrowing-getter branch July 14, 2023 06:29
@ahoppen ahoppen mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rintaro rintaro rintaro approved these changes

@bnbarham bnbarham bnbarham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahoppen @rintaro @bnbarham