Rename eof to endOfFile #1842
Merged
Rename eof to endOfFile #1842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
reviewed
Jun 26, 2023
CodeGeneration/Tests/ValidateSyntaxNodes/ValidateSyntaxNodes.swift
Outdated
Show resolved
Hide resolved
ahoppen
reviewed
Jun 26, 2023
CodeGeneration/Tests/ValidateSyntaxNodes/ValidateSyntaxNodes.swift
Outdated
Show resolved
Hide resolved
|
@mininny could you rebase your PR instead of merge main into it. |
mininny
force-pushed
the
1837-rename-eof-to-endOfFile
branch
from
16ad3b0 to
2abcb73
Compare
Of course! I've rebased the changes to main 👍 |
|
@kimdv Hi, if the reviewed code is fine, I was wondering if this could be tested and merged 😄 |
|
@swift-ci Please test |
|
Looks like the code isn’t formatted using |
…e EOF tokens as part of the normal SYNTAX_TOKENS
mininny
force-pushed
the
1837-rename-eof-to-endOfFile
branch
from
2abcb73 to
1b11c7f
Compare
|
@swift-ci Please test |
Yep! I ran the swift formatter. Thanks |
auto-merge was automatically disabled
July 10, 2023 10:59
Head branch was pushed to by a user without write access
mininny
force-pushed
the
1837-rename-eof-to-endOfFile
branch
from
1b11c7f to
76d9e28
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1837
rdar://111217077
This PR renames eof(or EOF) to endOfFile.
I've also noticed there was a FIXME where
eofwas treated specially inSYNTAX_TOKENS. I changed the TokenSpec to includeEndOfFileas a regularSYNTAX_TOKENS, and fixed places where eof was handled individually. In most cases, these special handlings could be covered with existing logic for other tokens.This is my first PR in swift-syntax, so please let me know if there's a better way to land these kind of changes.