Rename TokenKind.eof to TokenKind.endOfFile #1840
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TTOzzi
reviewed
Jun 25, 2023
| case eof | ||
| case endOfFile |
There was a problem hiding this comment.
Hello @mininny 👋
The subfiles in the directory generated are automatically generated through CodeGeneration.
(For example, TokenKind.swift is generated by CodeGeneration's TokenKindFile.swift.)
You need to change the code in CodeGeneration and refer to the instructions in these documents to generate the code 🙂
https://github.com/apple/swift-syntax/blob/main/CONTRIBUTING.md#generating-source-code
https://github.com/apple/swift-syntax/blob/main/CodeGeneration/README.md
There was a problem hiding this comment.
I see, thanks! I'll rebuild the project with codegen. It's my first time contributing here so I didn't realize it. Please disregard this PR for now :)
|
Closing in favor of #1842 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1837
rdar://111217077
This PR renames
TokenKind.eoftoTokenKind.endOfFileandTokenSyntax.eof()toTokenSyntax.endOfFile()