[5.9] Fix for some wrong attribute fix its #1688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
approved these changes
May 22, 2023
bnbarham
approved these changes
May 22, 2023
Comment on lines
+428
to
+438
| DiagnosticSpec( | ||
| locationMarker: "1️⃣", | ||
| message: #"expected '"' in string literal"#, | ||
| fixIts: [#"insert '"'"#] | ||
| ), | ||
| DiagnosticSpec( | ||
| locationMarker: "2️⃣", | ||
| message: #"expected '"' to end string literal"#, | ||
| fixIts: [#"insert '"'"#] | ||
| ), | ||
| ], |
There was a problem hiding this comment.
How difficult is it to make this a single diagnostic? Seems a little weird as two to me, ie. I would expect a surround '...' in '"'
There was a problem hiding this comment.
Filed #1691. We can take care of this on main, it’s not necessary to do it for Swift 5.9.
|
@swift-ci Please test |
|
@swift-ci please test |
…-of-quote-tokens Fix for some wrong attribute fix its
kimdv
force-pushed
the
kimdv/cherry-pick-fix-wrong-wrapping-of-quote-tokens
branch
from
2327497 to
eba6f40
Compare
|
@swift-ci please test |
|
@swift-ci please test windows |
1 similar comment
|
@swift-ci please test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_originallyDefinedIn,_unavailableFromAsyncand_expose. The parser tought it was an identifier so it skipped.Now it consumes an identifier and remap it so a string segment