Fix for some wrong attribute fix its #1566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Apr 21, 2023
kimdv
force-pushed
the
kimdv/fix-wrong-wrapping-of-quote-tokens
branch
2 times, most recently
from
1f8e07b to
f28cc4d
Compare
ahoppen
reviewed
Apr 24, 2023
ahoppen
approved these changes
Apr 25, 2023
kimdv
force-pushed
the
kimdv/fix-wrong-wrapping-of-quote-tokens
branch
from
f28cc4d to
7b33ca5
Compare
|
@swift-ci please test |
kimdv
force-pushed
the
kimdv/fix-wrong-wrapping-of-quote-tokens
branch
from
7b33ca5 to
bb57360
Compare
|
@swift-ci please test |
|
@swift-ci Please test Windows |
kimdv
added a commit
to kimdv/swift-syntax
that referenced
this pull request
Apr 26, 2023
…-of-quote-tokens Fix for some wrong attribute fix its
kimdv
added a commit
to kimdv/swift-syntax
that referenced
this pull request
May 22, 2023
…-of-quote-tokens Fix for some wrong attribute fix its
kimdv
added a commit
to kimdv/swift-syntax
that referenced
this pull request
May 23, 2023
…-of-quote-tokens Fix for some wrong attribute fix its
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is looking the same and there is a lot more attributes that properly have the same issue.
So I tought if it made sense to make something more generic that work in all cases without implementing it for each attribute.