Removed TODOs in testRecovery102/103/104 #1557
Merged
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ahoppen I was wondering if this was the right way to solve it. |
|
I also considered creating an ad-hoc node to represent this common error, but it seems excessive |
ahoppen
reviewed
Apr 20, 2023
CippoX
force-pushed
the
array-type-brackets-around-element-type
branch
from
5ddde20 to
2a77692
Compare
CippoX
changed the title
CippoX
force-pushed
the
array-type-brackets-around-element-type
branch
3 times, most recently
from
498908b to
a67a5e1
Compare
CippoX
force-pushed
the
array-type-brackets-around-element-type
branch
from
a67a5e1 to
620b007
Compare
kimdv
approved these changes
Apr 28, 2023
|
@swift-ci please test |
ahoppen
approved these changes
Apr 28, 2023
|
@swift-ci Please test Windows |
|
@swift-ci please test windows |
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
|
No problem. I’ll look for something else to work on in my free time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing testRecovery102/103/104