Removed TODOs

Author: CippoX

Sources/SwiftParser/Expressions.swift

@@ -1025,7 +1025,7 @@ extension Parser {
     // the token is a operator starts with '.', or the following token is '['.
     let rootType: RawTypeSyntax?
     if !self.currentToken.starts(with: ".") {
-      rootType = self.parseSimpleType(stopAtFirstPeriod: true, isRawKeyPathExprSyntax: true)
+      rootType = self.parseSimpleType(stopAtFirstPeriod: true)
     } else {
       rootType = nil
     }

Sources/SwiftParser/Types.swift

@@ -236,23 +236,13 @@ extension Parser {
   ///     member-type-identifier-base → simple-type | member-type-identifier
   @_spi(RawSyntax)
   public mutating func parseSimpleType(
-    stopAtFirstPeriod: Bool = false,
-    isRawKeyPathExprSyntax: Bool = false
+    stopAtFirstPeriod: Bool = false
   ) -> RawTypeSyntax {
     var base: RawTypeSyntax
     switch self.currentToken {
-    case TokenSpec(.identifier):
-      var lookahead = self.lookahead()
-      lookahead.consumeAnyToken()
-      if !isRawKeyPathExprSyntax,
-         let _ = lookahead.consume(if: .leftSquareBracket, followedBy: .integerLiteral),
-         lookahead.currentToken.rawTokenKind == .rightSquareBracket {
-        base = RawTypeSyntax(self.parseCollectionType())
-      } else {
-        base = self.parseTypeIdentifier()
-      }
     case TokenSpec(.Self),
-      TokenSpec(.Any):
+      TokenSpec(.Any),
+      TokenSpec(.identifier):
       base = self.parseTypeIdentifier()
     case TokenSpec(.leftParen):
       base = RawTypeSyntax(self.parseTupleTypeBody())

Sources/SwiftParserDiagnostics/ParseDiagnosticsGenerator.swift

@@ -391,22 +391,6 @@ public class ParseDiagnosticsGenerator: SyntaxAnyVisitor {
   }
 
   // MARK: - Specialized diagnostic generation
-  
- public override func visit(_ node: ArrayTypeSyntax) -> SyntaxVisitorContinueKind {
-    if shouldSkip(node) {
-      return .skipChildren
-    }
-    if let unexpectedIdentifier = node.unexpectedBeforeLeftSquareBracket,
-       let unexpectedIntegerLiteral = node.unexpectedBetweenElementTypeAndRightSquareBracket,
-       node.elementType.isMissingAllTokens {
-      addDiagnostic(
-        node.leftSquareBracket,
-        .arrayTypesAreWrittenWithTheBracketsAround,
-        handledNodes: [unexpectedIdentifier.id, unexpectedIntegerLiteral.id, node.elementType.id]
-      )
-    }
-    return .visitChildren
-  }
 
   public override func visit(_ node: ArrowExprSyntax) -> SyntaxVisitorContinueKind {
     if shouldSkip(node) {

Sources/SwiftParserDiagnostics/ParserDiagnosticMessages.swift

@@ -89,9 +89,6 @@ extension DiagnosticMessage where Self == StaticParserError {
   public static var allStatmentsInSwitchMustBeCoveredByCase: Self {
     .init("all statements inside a switch must be covered by a 'case' or 'default' label")
   }
-  public static var arrayTypesAreWrittenWithTheBracketsAround: Self {
-    .init("array types are now written with the brackets around the element type")
-  }
   public static var associatedTypeCannotUsePack: Self {
     .init("associated types cannot be variadic")
   }

Tests/SwiftParserTest/translated/RecoveryTests.swift

@@ -1273,8 +1273,7 @@ final class RecoveryTests: XCTestCase {
       }
       """,
       diagnostics: [
-        // TODO: FixIt
-        DiagnosticSpec(message: "array types are now written with the brackets around the element type")
+        DiagnosticSpec(message: "unexpected code '[0]' in function")
       ]
     )
   }
@@ -1289,8 +1288,7 @@ final class RecoveryTests: XCTestCase {
       }
       """,
       diagnostics: [
-        // TODO: FixIt
-        DiagnosticSpec(message: "array types are now written with the brackets around the element type")
+        DiagnosticSpec(message: "unexpected code '[0_1]' in function")
       ]
     )
   }
@@ -1305,8 +1303,7 @@ final class RecoveryTests: XCTestCase {
       }
       """,
       diagnostics: [
-        // TODO: FixIt
-        DiagnosticSpec(message: "array types are now written with the brackets around the element type")
+        DiagnosticSpec(message: "unexpected code '[0b1]' in function")
       ]
     )
   }