Skip to content

Prefer the first lexical error in a string literal segment #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2023
Merged

Prefer the first lexical error in a string literal segment #1553

merged 1 commit into from
Apr 22, 2023

Conversation

cbjeukendrup
Copy link
Contributor

Resolves: #1480

@cbjeukendrup cbjeukendrup requested a review from ahoppen as a code owner April 15, 2023 19:00
ahoppen
ahoppen approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. This looks great!

@ahoppen
Copy link
Member

ahoppen commented Apr 17, 2023

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge April 17, 2023 20:17
@ahoppen
Copy link
Member

ahoppen commented Apr 20, 2023

Could you format the files as described in https://github.com/apple/swift-syntax/blob/main/CONTRIBUTING.md#formatting?

auto-merge was automatically disabled April 21, 2023 10:51

Head branch was pushed to by a user without write access

@cbjeukendrup cbjeukendrup force-pushed the prefer_first_lex_err_in_string_literal branch from ca4ec6e to f7c66ea Compare April 21, 2023 10:51
@kimdv
Copy link
Contributor

kimdv commented Apr 21, 2023

@swift-ci please test

@cbjeukendrup
Copy link
Contributor Author

When I try to build swift-format using swift build -c release, it fails with error: 'swift-format': product 'SwiftParser' required by package 'swift-format' target 'swift-format' not found in package 'swift-syntax'.. And when I use swift-format from HomeBrew, it touches some files that I had not modified. So I've committed only the changes to the file that I modified, so I hope it will be fine.

@ahoppen
Copy link
Member

ahoppen commented Apr 21, 2023

That's odd. How exactly are you building swift-format, which branch are you building and is your checkout up-to-date?

@cbjeukendrup
Copy link
Contributor Author

It looks like I've just fixed it by removing Package.resolved from my swift-format folder. And indeed the self-built version of swift-format does not introduce unexpected changes. So everything seems fine now!

@ahoppen
Copy link
Member

ahoppen commented Apr 21, 2023

@swift-ci Please test Windows

@ahoppen ahoppen enabled auto-merge April 21, 2023 22:44
@ahoppen ahoppen merged commit 7650238 into swiftlang:main Apr 22, 2023
@cbjeukendrup cbjeukendrup deleted the prefer_first_lex_err_in_string_literal branch April 22, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefer the first lexical error in a string literal segment
3 participants
@cbjeukendrup @ahoppen @kimdv