Make installer window taller #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhegazy here is 724x2000 SVG version of the original asset: swift_side@4x.svg. Hope this would fit nicely for new requirements. As far as I remember, WiX could use SVG directly, converting it to bitmap underneath. That's why even SVG is upscaled to 4x size (so we get 4x bitmap in the end). I am wondering if new WiX able to bundle SVG as is, rendering it in runtime. Anyway, the asset should be useful. |
|
thanks @lxbndr ! appreciate it. yeah, the wix installer does not support svg natively so had to convert. i did commit both asserts though to make it easier for future changes |
|
screenshot in the description updated to match latest changes and new asset. |
compnerd
approved these changes
May 27, 2025
|
Kicked off a test, can merge once that comes back green. |
etcwilde
approved these changes
May 27, 2025
This was referenced Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make room for additional options, this is a short term fix, to make the installer window taller. this is an alternative approach to #423.
The side bar art has solid colors, so extending it works without impacting image quality or aspect ratio.
here is what the result looks like:
