SR-3477: replace unsafeBitCast by withoutActuallyEscaping #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that withoutActuallyEscaping is implemented, use it instead of unsafeBitCast to allow passing a closure capturing a non-escaping block down to the C implementation of dispatch_data_apply (which does not actually escape its block argument).
MadCoder
approved these changes
Jan 4, 2017
|
@swift-ci please test |
|
CI failure was on swiftpm test. both dispatch and foundation tests passed. Should be ok to merge. |
das
pushed a commit
that referenced
this pull request
Feb 21, 2017
SR-3477: replace unsafeBitCast by withoutActuallyEscaping Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that withoutActuallyEscaping is implemented, use it instead
of unsafeBitCast to allow passing a closure capturing a non-escaping
block down to the C implementation of dispatch_data_apply (which does
not actually escape its block argument).