Replace uses of @_silgen_name with uses of a shims header. #192
Conversation
|
@swift-ci Please test |
jrose-apple
force-pushed
the
excise-silgen_name-once-more
branch
from
cd8f4ff to
4dc1f0b
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
@phausler, @dgrove-oss, have you seen this before? |
|
nope, have not seen that particular failure before. Looks like a failure inside of the kqueue implementation |
|
The Dispatch tests did pass anyway. |
|
@jrose-apple I assume we still want to get this PR merged. Do you want me to pick it up and resolve the conflicts (plus another conflict I'm about to add with #198) or do you have time to resolve them yourself? |
|
You're welcome to pick them up if you want. They're not urgent, just general cleanup as we try to get away from the awfulness of matching up unrelated declarations. |
|
The dispatch conflicts were easy to resolve, but we need to get swiftlang/swift#6033 merged before we can merge this one (otherwise it won't build). Since it seems like a low priority thing, I'm dropping it for now. |
jrose-apple
force-pushed
the
excise-silgen_name-once-more
branch
from
4dc1f0b to
42588f5
Compare
|
Picked this up again, because why not finish it off. swiftlang/swift#6033 |
|
Oops, this probably isn't correct because I forgot to remove SWIFT_CC from things. |
jrose-apple
force-pushed
the
excise-silgen_name-once-more
branch
from
42588f5 to
dd953ed
Compare
|
@swift-ci Please test |
|
@swift-ci Please test |
|
Hm, swift-ci… swiftlang/swift#6033 |
The header is in the main Swift repo because it's shared with the Darwin Dispatch overlay. No intended functionality change.
jrose-apple
force-pushed
the
excise-silgen_name-once-more
branch
from
dd953ed to
d7c4fc7
Compare
|
swiftlang/swift#6033 |
1 similar comment
|
swiftlang/swift#6033 |
|
… swiftlang/swift#6033 |
|
swiftlang/swift#6033 |
1 similar comment
|
swiftlang/swift#6033 |
|
Okay, I'll try doing it the other way around. |
|
Passed here: swiftlang/swift#6033 (comment) |
Replace uses of @_silgen_name with uses of a shims header. Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Said shims header is in the main Swift repo because it's shared with the Darwin Dispatch overlay. This is the same effort as swiftlang/swift#5854, but for corelibs.
No intended functionality change.