Delete _os_log_set_nscf_formatter related lines to make the framework run on macOS 10.11
#784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… macOS 10.11 The symbol does exist in libSystem.B.dylib on 10.12 but does not on 10.11.
This was referenced Jan 11, 2017
|
@swift-ci please test |
|
Actually - please just delete these lines. |
|
|
ikesyo
changed the title
_os_log_set_nscf_formatter to make the framework run on macOS 10.11_os_log_set_nscf_formatter related lines to make the framework run on macOS 10.11
|
Cool, thanks. |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symbol does exist in
libSystem.B.dylibon 10.12 but does not on 10.11 (which was introduced in #709).The issue should have been happening in swiftlang/swift-corelibs-xctest#176 and swiftlang/swift-corelibs-xctest#182.
The fix is based on this: https://developer.apple.com/library/content/documentation/MacOSX/Conceptual/BPFrameworks/Concepts/WeakLinking.html.