Skip to content

Import CoreFoundation changes from Sierra #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 8, 2016

Conversation

phausler
Copy link
Contributor

@phausler phausler commented Nov 8, 2016

No description provided.

@phausler
Copy link
Contributor Author

phausler commented Nov 8, 2016

@swift-ci Please test

3 similar comments
@phausler
Copy link
Contributor Author

phausler commented Nov 8, 2016

@swift-ci Please test

@phausler
Copy link
Contributor Author

@swift-ci Please test

@phausler
Copy link
Contributor Author

@swift-ci Please test

@parkera
Copy link
Contributor

parkera commented Nov 18, 2016

@swift-ci please test

@phausler
Copy link
Contributor Author

phausler commented Dec 7, 2016

@swift-ci please test

@phausler
Copy link
Contributor Author

phausler commented Dec 8, 2016

@parkera can you get the CI to test this?

@parkera
Copy link
Contributor

parkera commented Dec 8, 2016

@swift-ci please test and merge

@parkera
Copy link
Contributor

parkera commented Dec 8, 2016

@emish @erg we're having problems kicking off the CI again from this repo.

@swift-ci swift-ci merged commit 173e9ea into swiftlang:master Dec 8, 2016
@parkera
Copy link
Contributor

parkera commented Dec 8, 2016

I think the status never appeared, but it looks like it did actually run.

kastiglione added a commit to kastiglione/swift-corelibs-foundation that referenced this pull request Jan 31, 2017
The change made in swiftlang#663 were overwritten by swiftlang#709. This change restores the switch from `#import` to `#include`.

The reason for this change is: Clang's MSVC compatibility does not handle `#import` statements outside of of objc.

> #import of type library is an unsupported Microsoft feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants