Skip to content

Allow numeric types in NSNumberFormatter.string(for:)[SR-2477] #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2016

Conversation

pushkarnk
Copy link
Member

@pushkarnk pushkarnk commented Sep 16, 2016

Reported by https://bugs.swift.org/browse/SR-2477

In the absence of coercion of Swift types to Foundation types on Linux, this is to bring about functional similarity with Darwin.

Copy link
Contributor

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks for the tests too

@phausler
Copy link
Contributor

@swift-ci Please test

@phausler phausler merged commit d3872cb into swiftlang:master Sep 21, 2016
pushkarnk pushed a commit to pushkarnk/swift-corelibs-foundation that referenced this pull request Sep 23, 2016
pushkarnk pushed a commit to pushkarnk/swift-corelibs-foundation that referenced this pull request Sep 23, 2016
@pushkarnk pushkarnk deleted the nsnumber branch September 24, 2016 04:30
parkera pushed a commit that referenced this pull request Sep 26, 2016
* Test case to test TimeZone.localizedName

* Allow httpAdditionalHeaders to contain Strings or NSStrings (#625)

* Switch to Error from NSError for API conformance

* Fix for a URLSession crash (SR-2630)

* If present, pass URLRequest.httpBody to the dataTask (#633)

* Set Content-Type to application/x-www-form-urlencoded for POST requests

* Update NSURLSession.swift

* Fix for SR-2631 and implementation of URLSession.finishTasksAndInvalidate

* Allow numeric types in NSNumberFormatter.string(for:)[SR-2477] (#643)

* Fix for [SR-2486] Crash in NSDictionary.description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants