SR-2617: URLSession.dataTask() ignores httpBody

[seabaylea]

SR-2617 reports that if you create a URLRequest with a httpBody set, and then try to create a session using URLSession.dataTask(), the httpBody is ignored.

This is because the call to URLSession.dataTask() creates a task with the following constructor:

URLSessionDataTask(session: self, request: r, taskIdentifier: i)

which in turn calls:

init(session: session, request: request, taskIdentifier: taskIdentifier, body: .none)

ie, we create a task with no body.

I've therefore made a change to pass through URLRequest.httpBody if one exists.

The reported bug has a second issue: the request is a POST, and we're not setting "Content-Type" : "application/x-www-form-urlencoded". I'll look at fixing that separately.

[parkera]

@swift-ci please test

[zmeyc]

In some situations httpBody is still not sent. Below is the code which reproduces the issue. If "Content-Type" line is uncommented, second dataTask won't send httpBody:

import Foundation
import Dispatch

var req = URLRequest(url: URL(string: "http://httpbin.org/post")!)
req.httpMethod = "POST"
req.httpBody = "a=b&c=d".data(using: .utf8)
//req.setValue("application/x-www-form-urlencoded", forHTTPHeaderField: "Content-Type")

let sesh = URLSession(configuration: URLSessionConfiguration.default)

let dataTask1 = sesh.dataTask(with: req) { data, _, _ in
            print(String(data: data!, encoding: .utf8)!)
}
dataTask1.resume()

let dataTask2 = sesh.dataTask(with: req) { data, _, _ in
            print(String(data: data!, encoding: .utf8)!)
}
dataTask2.resume()

dispatchMain()