Skip to content

move samples into a subdirectory #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 7, 2020
Merged

move samples into a subdirectory #72

merged 9 commits into from
May 7, 2020

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented May 6, 2020

No description provided.

tomerd and others added 4 commits March 25, 2020 16:08
motivation: easier to reason about examples

changes:
* move each example to its own target
* update deployment script to prompt for desired target when multiple targets exist
* add code comments on what the example is about
* add feature-reach example (CurrencyExchange) to help testing use of Foundation features that require curl and libxml
motivation: demonstrate how to deploy with SAM

changes:
* Add a SAM template for deploying the lambdas to AWS. 
* Updated README with instructions on how to do this.
@tomerd tomerd linked an issue May 6, 2020 that may be closed by this pull request
@tomerd
Copy link
Contributor Author

tomerd commented May 6, 2020

fixes #71

Copy link
Contributor

@yim-lee yim-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to correct directory name for "EndToEndDebugging" otherwise LGTM.

@tomerd tomerd force-pushed the move-samples branch 2 times, most recently from 1f1b51e to 850608a Compare May 7, 2020 02:37
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<Workspace
version = "1.0">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want to include the README.md here as well. Increases the chances that it is read.

Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I pointed out, maybe we want to add the README.md to the Workspace. Otherwise LGTM.

motivation: easier to find and reason about

changes: move exmaples from a seperate repo into a subdirectory
fabianfett added 3 commits May 7, 2020 09:45
motivation: support DynamoDB triggers

changes: added DynamoDB Event abstractions and encoders/decoders
…LambdaRuntimeCore (#41)

motivation: enable non-foundation module for performance sensitive use cases

changes: 
* rename AWSLambdaRuntime to AWSLambdaRuntimeCore 
* create AWSLambdaRuntime for Foundation dependent functionality 
* have (new) AWSLambdaRuntime export AWSLambdaRuntimeCore
* adjust tests
@tomerd tomerd merged commit 9310ad8 into master May 7, 2020
@tomerd tomerd deleted the move-samples branch May 7, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move samples as a subdirectory of this project?
4 participants