Added DynamoDB Event #65
Conversation
fabianfett
force-pushed
the
dynamodb-event
branch
from
92ad4f2 to
2251364
Compare
fabianfett
force-pushed
the
dynamodb-event
branch
from
9f5778d to
92513f9
Compare
|
|
||
| extension DynamoDB { | ||
| public struct Decoder { | ||
| @usableFromInline var userInfo: [CodingUserInfoKey: Any] = [:] |
There was a problem hiding this comment.
if we want to have this call inlined: yes
@inlinable public func decode<T: Decodable>(_ type: T.Type, from value: AttributeValue)
throws -> T
{
let decoder = _DecoderImpl(userInfo: userInfo, from: value, codingPath: [])
return try decoder.decode(T.self)
}There was a problem hiding this comment.
right, I had a conversation with @weissi a while back on the effectiveness of @inlinable in certain uses case. he may have an opinion here as well
There was a problem hiding this comment.
In this case, it's the right call because it's generic and we may be able to inline enough for the whole thing to get specialised. I doubt it'll actually fully work in this case but that's not a good reason not to try.
As a thought for Lambda though: You may just want to recommend -Xswiftc -cross-module-optimization which then makes all those @inlinable/@usableFromInlines superfluous.
| } | ||
| } | ||
|
|
||
| @usableFromInline internal struct _DecoderImpl: Swift.Decoder { |
There was a problem hiding this comment.
a bit of duplication between the different containers, tho not sure if worth making DRYer. your call.
motivation: support DynamoDB triggers changes: added DynamoDB Event abstractions and encoders/decoders
No description provided.