Skip to content

Add Sendable support #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

fabianfett
Copy link
Member

@fabianfett fabianfett commented Apr 20, 2022

This is an alternative to: #13. The main difference is that we don't introduce new Protocols, which only inherit from Decodable and Sendable. For this reason adopters don't need to learn about our helper protocols. Let me know what you think.

As a side note: I still really dislike the Date propertyWrappers and I still consider them an anti-pattern, which only purpose is to work around Codable limitations.

extension AppSyncEvent.Identity.CognitoUserPoolIdentity: Sendable {}
extension AppSyncEvent.Identity.IAMIdentity: Sendable {}
extension AppSyncResponse: Sendable where ResultType: Sendable {}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kill empty line

Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small formatting issue

Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabianfett fabianfett merged commit 2a118fb into swift-server:main Apr 21, 2022
@fabianfett fabianfett deleted the ff-add-sendable-support branch April 21, 2022 06:51
heyzooi pushed a commit to heyzooi/swift-aws-lambda-events that referenced this pull request Apr 22, 2025
* fix badge

* Add semantic version label check

* disable yaml linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants