Skip to content

adjustments to sendable #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Apr 15, 2022

motivation: events may be used in an async context and as such musct conform to Sendable

changes:

  • define common abstraction for Sendable & Codable
  • conform all events Sendable

motivation: events may be used in an async context and as such musct conform to Sendable

changes:
* define common abstraction for Sendable & Codable
* conform all events Sendable
Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Cleans up a bit of the code as well given events only need to be decodable

@fabianfett fabianfett mentioned this pull request Apr 20, 2022
@fabianfett
Copy link
Member

Superseded by #15.

@fabianfett fabianfett closed this Apr 21, 2022
heyzooi pushed a commit to heyzooi/swift-aws-lambda-events that referenced this pull request Apr 22, 2025
Rename pull_request.yaml to pull_request.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants