Add end-to-end tests for async/await #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadoba
force-pushed
the
dn-async-await-tests
branch
from
ae3d46a to
e3e9e93
Compare
dnadoba
force-pushed
the
dn-async-await-tests
branch
2 times, most recently
from
ccf91de to
aee5202
Compare
save progress save progress 2
dnadoba
force-pushed
the
dn-async-await-tests
branch
from
aee5202 to
bc7e2d0
Compare
fabianfett
reviewed
Dec 16, 2021
| return XCTFail("wrong error \(error)") | ||
| } | ||
| XCTAssertTrue( | ||
| [HTTPClientError.connectTimeout, .tlsHandshakeTimeout].contains(httpError), |
There was a problem hiding this comment.
I don't think tlsHandshakeTimeout is a possible error here. We will never have an actual connection here, so tlsHandshake will never be started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.