Respect deadline on new HTTPClient.execute for async/await #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadoba
force-pushed
the
dn-deadline-fix
branch
from
3d67a62 to
e17f864
Compare
save progress save progress 2
dnadoba
force-pushed
the
dn-deadline-fix
branch
2 times, most recently
from
1210f9a to
c359067
Compare
dnadoba
force-pushed
the
dn-deadline-fix
branch
from
c359067 to
f9b040e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to schedule a timeout timer for the user defined deadline and just use it as a connection timeout.