Skip to content

should ignore @typescript-eslint/indent in template #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

meowtec
Copy link

@meowtec meowtec commented Mar 8, 2021

No description provided.

@dummdidumm
Copy link
Member

Could you provide a short explanation why this is needed and add a test case that confirms the new behavior?

@meowtec
Copy link
Author

meowtec commented Mar 8, 2021

Could you provide a short explanation why this is needed and add a test case that confirms the new behavior?

When we using @typescript-eslint, we usually disable indent and enable @typescript-eslint/indent.

indent: 0,
'@typescript-eslint/indent': ['error', 'tab'],

Now ESLint is not working as expected:

<div>{some expression}</div>
      ~~~~~~~~~~~~~~~
      Expected indentation of 2 spaces but found 0. eslint@typescript-eslint/indent

@meowtec
Copy link
Author

meowtec commented Mar 8, 2021

Test case added.

The CI broken, I don't know why but I think is not my fault.

@meowtec
Copy link
Author

meowtec commented Mar 11, 2021

CI failed because of svelte@3.35

@dummdidumm
Copy link
Member

Superseeded by #101 . Still thanks for your contribution!

@Conduitry Conduitry closed this Apr 23, 2021
@Conduitry
Copy link
Member

#101 has been released in 3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants