Skip to content

Consider @typescript-eslint's rules for invalid messages #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2021

Conversation

sxxov
Copy link
Contributor

@sxxov sxxov commented Mar 16, 2021

Currently when using the @typescript-eslint plugin, there are some parts where they some rules apply unnecessarily.
I found it's because I'm using some their alternative rules, which are enabled under a namespace (eg. @typescript-eslint/indent), and thus not properly marked as invalid when post-processing.

Before:
image

After:
image

@sxxov
Copy link
Contributor Author

sxxov commented Mar 16, 2021

Something notable with this how it's different from #98. This fixes the internal checking and enables users to use the rules instead of disabling them.

Edit: and oh yeah, and the same CI things as above PR. i didn't touch anything that could be breaking, just added cases to is_valid_message

@dummdidumm
Copy link
Member

Not sure what you mean by the "how it's different from #98" sentence, you both change the same line for the one rule - you add one more though. Could you add a test that checks that these new false positives are filtered out? Thanks!

@sxxov
Copy link
Contributor Author

sxxov commented Mar 16, 2021

@dummdidumm

Not sure what you mean by the "how it's different from #98" sentence, you both change the same line for the one rule - you add one more though.

Ah, that's very much my bad. I read template and thought he meant like code templates (doh).

Could you add a test that checks that these new false positives are filtered out? Thanks!

Yep, give me a bit

@Conduitry Conduitry merged commit 4715a5c into sveltejs:master Apr 23, 2021
@Conduitry
Copy link
Member

This has been released in 3.2.0 - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants