Skip to content

Support for NUCLEO-F031K6 variant #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 10, 2020
Merged

Support for NUCLEO-F031K6 variant #974

merged 11 commits into from
Mar 10, 2020

Conversation

N0rbert
Copy link
Contributor

@N0rbert N0rbert commented Mar 8, 2020 •
edited
Loading

Summary

As it was recommended in #722 (comment) I have added new variant for my NUCLEO-F031K6 board.
This is my first stm32duino variant. I tested it with 1.8.0 and then rebased to master branch.

This PR fixes/implements the following features

  • support NUCLEO-F031K6 board

The I2C bus is located on D4 (SDA) and D5 (SCL).

I have done some validation - tested the following functionality:

  • Blink
  • digitalWrite
  • digitalRead
  • analogRead and serial port monitor with AnalogReadSerial example on all Arduino Nano channels (from A0 to A6).
  • analogWrite with AnalogWriteMega on all digital channels from D0 to D13
  • I2C by running i2cdetect and by viewing images on SSD1306 display

I have not yet tested the SPI bus, but I believe that it will operate normally on D10 (SPI_NSS), D11 (SPI_MOSI), D12 (SPI_MISO) and D13 (SPI_CLK).

Finally I formated the code with Astyle.

I hope that this variant will be useful for somebody. Testers are also welcome.

@N0rbert N0rbert changed the title Support for NUCLEO-F031K6 varian Support for NUCLEO-F031K6 variant Mar 8, 2020
@N0rbert
Update PeripheralPins.c
dd1783a 
ran astyle for this single file
@fpistm fpistm requested a review from ABOSTM March 9, 2020 06:51
@fpistm fpistm added the new variant Add support of new bard label Mar 9, 2020
@fpistm
Copy link
Member

fpistm commented Mar 9, 2020

Hi @N0rbert
Thanks for your contribution. We will review it.

ABOSTM
ABOSTM suggested changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @N0rbert ,
Thank you for this PR.
Great Job.
Just few remarks about some pins

@N0rbert N0rbert requested a review from ABOSTM March 9, 2020 11:32
ABOSTM
ABOSTM suggested changes Mar 9, 2020
View reviewed changes
N0rbert added 2 commits March 9, 2020 15:50
@N0rbert
uncommented lines
882d5be 
uncommented lines according to review process
@N0rbert
fixed TIMs - one pin per TIM
c48a04a
@N0rbert N0rbert requested a review from ABOSTM March 9, 2020 17:37
@N0rbert
Copy link
Contributor Author

N0rbert commented Mar 9, 2020

I have committed all the stuff. Also I have tested SPI via SD card.
So for now PR is ready. Thank you!

ABOSTM
ABOSTM suggested changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@N0rbert N0rbert requested a review from ABOSTM March 10, 2020 10:50
fpistm
fpistm reviewed Mar 10, 2020
View reviewed changes
@fpistm fpistm merged commit abd073d into stm32duino:master Mar 10, 2020
@fpistm fpistm added this to the 1.9.0 milestone Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm left review comments

@ABOSTM ABOSTM ABOSTM approved these changes

Assignees
No one assigned
Labels
new variant Add support of new bard
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@N0rbert @fpistm @ABOSTM