Skip to content

feat: refactor and add protocol support to stats/base/nanminabs #6345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Jun 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
1e88fed
Create accessors.js
Kaushikgtm Mar 24, 2025
6ce5e2f
Update nanminabs.js
Kaushikgtm Mar 24, 2025
cd1cffc
Update ndarray.js
Kaushikgtm Mar 24, 2025
5288bf3
Update test.nanminabs.js
Kaushikgtm Mar 24, 2025
5485348
Update test.ndarray.js
Kaushikgtm Mar 24, 2025
53c7a60
Update README.md
Kaushikgtm Mar 24, 2025
2212af9
Update benchmark.js
Kaushikgtm Mar 24, 2025
1d6b606
Update benchmark.ndarray.js
Kaushikgtm Mar 24, 2025
f45c5c7
Update index.d.ts
Kaushikgtm Mar 24, 2025
da46e37
Update test.ts
Kaushikgtm Mar 24, 2025
1ab7879
Update index.js
Kaushikgtm Mar 24, 2025
178e066
Update repl.txt
Kaushikgtm Mar 24, 2025
0ab9225
Update accessors.js
Kaushikgtm Mar 25, 2025
3700f20
Update test.nanminabs.js
Kaushikgtm Mar 25, 2025
857973a
Update accessors.js
Kaushikgtm Mar 25, 2025
6230aa3
Update accessors.js
Kaushikgtm Mar 25, 2025
9807141
Update nanminabs.js
Kaushikgtm Mar 25, 2025
a47a21e
Update repl.txt
Kaushikgtm Mar 25, 2025
9274896
Update repl.txt
Kaushikgtm Mar 25, 2025
8b9cba8
Update README.md
Kaushikgtm Mar 25, 2025
b5b1523
Update README.md
Kaushikgtm Mar 25, 2025
e80b90e
Update README.md
Kaushikgtm Mar 25, 2025
612e0a8
Update README.md
Kaushikgtm Mar 25, 2025
a672185
Update repl.txt
Kaushikgtm Mar 25, 2025
7fbca71
Update repl.txt
Kaushikgtm Mar 25, 2025
433a6e6
Update repl.txt
Kaushikgtm Mar 25, 2025
fef60be
Update repl.txt
Kaushikgtm Mar 25, 2025
1a99c85
Update repl.txt
Kaushikgtm Mar 25, 2025
2fca3d1
Update test.ndarray.js
Kaushikgtm Mar 26, 2025
bb1f043
Update test.ndarray.js
Kaushikgtm Mar 26, 2025
590b702
Merge branch 'develop' into Kaushikgtm-nanminabs
gururaj1512 Jun 4, 2025
85849de
test: fix test cases
gururaj1512 Jun 4, 2025
03ec98a
fix: implementation
gururaj1512 Jun 4, 2025
1ef0ea4
bench: update benchmarks
gururaj1512 Jun 4, 2025
c91cf63
docs: update examples docs and README
gururaj1512 Jun 4, 2025
9001c23
test: minor cleanups
gururaj1512 Jun 4, 2025
8308325
Update repl.txt
gururaj1512 Jun 4, 2025
8f8e1f6
fix: minor cleanups
gururaj1512 Jun 4, 2025
80a3662
Apply suggestions from code review
kgryte Jun 5, 2025
d0d90c1
test: update descriptions
kgryte Jun 5, 2025
8d23f21
test: update descriptions
kgryte Jun 5, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 24 additions & 35 deletions lib/node_modules/@stdlib/stats/base/nanminabs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,33 +36,29 @@ limitations under the License.
var nanminabs = require( '@stdlib/stats/base/nanminabs' );
```

#### nanminabs( N, x, stride )
#### nanminabs( N, x, strideX )

Computes the minimum absolute value of a strided array `x`, ignoring `NaN` values.
Computes the minimum absolute value of a strided array, ignoring `NaN` values.

```javascript
var x = [ 1.0, -2.0, NaN, 2.0 ];
var N = x.length;

var v = nanminabs( N, x, 1 );
var v = nanminabs( x.length, x, 1 );
// returns 1.0
```

The function has the following parameters:

- **N**: number of indexed elements.
- **x**: input [`Array`][mdn-array] or [`typed array`][mdn-typed-array].
- **stride**: index increment for `x`.
- **strideX**: stride length for `x`.

The `N` and `stride` parameters determine which elements in `x` are accessed at runtime. For example, to compute the minimum absolute value of every other element in `x`,
The `N` and stride parameters determine which elements in the strided array are accessed at runtime. For example, to compute the minimum absolute value of every other element in `x`,

```javascript
var floor = require( '@stdlib/math/base/special/floor' );

var x = [ 1.0, 2.0, 2.0, -7.0, -2.0, 3.0, 4.0, 2.0, NaN, NaN ];
var N = floor( x.length / 2 );

var v = nanminabs( N, x, 2 );
var v = nanminabs( 5, x, 2 );
// returns 1.0
```

Expand All @@ -72,42 +68,35 @@ Note that indexing is relative to the first index. To introduce an offset, use [

```javascript
var Float64Array = require( '@stdlib/array/float64' );
var floor = require( '@stdlib/math/base/special/floor' );

var x0 = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, NaN, NaN, 4.0 ] );
var x1 = new Float64Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element

var N = floor( x0.length / 2 );

var v = nanminabs( N, x1, 2 );
var v = nanminabs( 4, x1, 2 );
// returns 1.0
```

#### nanminabs.ndarray( N, x, stride, offset )
#### nanminabs.ndarray( N, x, strideX, offsetX )

Computes the minimum absolute value of a strided array, ignoring `NaN` values and using alternative indexing semantics.

```javascript
var x = [ 1.0, -2.0, NaN, 2.0 ];
var N = x.length;

var v = nanminabs.ndarray( N, x, 1, 0 );
var v = nanminabs.ndarray( x.length, x, 1, 0 );
// returns 1.0
```

The function has the following additional parameters:

- **offset**: starting index for `x`.
- **offsetX**: starting index for `x`.

While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying `buffer`, the `offset` parameter supports indexing semantics based on a starting index. For example, to calculate the minimum absolute value for every other value in `x` starting from the second value
While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying buffer, the offset parameter supports indexing semantics based on a starting index. For example, to calculate the minimum absolute value for every other element in `x` starting from the second element

```javascript
var floor = require( '@stdlib/math/base/special/floor' );

var x = [ 2.0, 1.0, 2.0, -2.0, -2.0, NaN, NaN, 2.0, 3.0, 4.0 ];
var N = floor( x.length / 2 );

var v = nanminabs.ndarray( N, x, 2, 1 );
var v = nanminabs.ndarray( 5, x, 2, 1 );
// returns 1.0
```

Expand All @@ -120,6 +109,7 @@ var v = nanminabs.ndarray( N, x, 2, 1 );
## Notes

- If `N <= 0`, both functions return `NaN`.
- Both functions support array-like objects having getter and setter accessors for array element access (e.g., [`@stdlib/array/base/accessor`][@stdlib/array/base/accessor]).
- Depending on the environment, the typed versions ([`dnanminabs`][@stdlib/stats/strided/dnanminabs], [`snanminabs`][@stdlib/stats/strided/snanminabs], etc.) are likely to be significantly more performant.

</section>
Expand All @@ -133,22 +123,19 @@ var v = nanminabs.ndarray( N, x, 2, 1 );
<!-- eslint no-undef: "error" -->

```javascript
var randu = require( '@stdlib/random/base/randu' );
var round = require( '@stdlib/math/base/special/round' );
var Float64Array = require( '@stdlib/array/float64' );
var uniform = require( '@stdlib/random/base/uniform' );
var filledarrayBy = require( '@stdlib/array/filled-by' );
var bernoulli = require( '@stdlib/random/base/bernoulli' );
var nanminabs = require( '@stdlib/stats/base/nanminabs' );

var x;
var i;

x = new Float64Array( 10 );
for ( i = 0; i < x.length; i++ ) {
if ( randu() < 0.2 ) {
x[ i ] = NaN;
} else {
x[ i ] = round( (randu()*100.0) - 50.0 );
function rand() {
if ( bernoulli( 0.8 ) < 1 ) {
return NaN;
}
return uniform( -50.0, 50.0 );
}

var x = filledarrayBy( 10, 'float64', rand );
console.log( x );

var v = nanminabs( x.length, x, 1 );
Expand Down Expand Up @@ -183,6 +170,8 @@ console.log( v );

[mdn-array]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array

[@stdlib/array/base/accessor]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/array/base/accessor

[mdn-typed-array]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray

<!-- <related-links> -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,30 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var bernoulli = require( '@stdlib/random/base/bernoulli' );
var filledarrayBy = require( '@stdlib/array/filled-by' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pow = require( '@stdlib/math/base/special/pow' );
var pkg = require( './../package.json' ).name;
var nanminabs = require( './../lib/nanminabs.js' );
var nanminabs = require( './../lib/main.js' );


// FUNCTIONS //

/**
* Returns a random value.
*
* @private
* @returns {number} random number
*/
function rand() {
if ( bernoulli( 0.8 ) < 1 ) {
return NaN;
}
return uniform( -10.0, 10.0 );
}

/**
* Creates a benchmark function.
*
Expand All @@ -38,17 +53,7 @@ var nanminabs = require( './../lib/nanminabs.js' );
* @returns {Function} benchmark function
*/
function createBenchmark( len ) {
var x;
var i;

x = [];
for ( i = 0; i < len; i++ ) {
if ( randu() < 0.2 ) {
x.push( NaN );
} else {
x.push( ( randu()*20.0 ) - 10.0 );
}
}
var x = filledarrayBy( len, 'generic', rand );
return benchmark;

function benchmark( b ) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var uniform = require( '@stdlib/random/base/uniform' );
var bernoulli = require( '@stdlib/random/base/bernoulli' );
var filledarrayBy = require( '@stdlib/array/filled-by' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pow = require( '@stdlib/math/base/special/pow' );
var pkg = require( './../package.json' ).name;
Expand All @@ -30,6 +32,19 @@ var nanminabs = require( './../lib/ndarray.js' );

// FUNCTIONS //

/**
* Returns a random value.
*
* @private
* @returns {number} random number
*/
function rand() {
if ( bernoulli( 0.8 ) < 1 ) {
return NaN;
}
return uniform( -10.0, 10.0 );
}

/**
* Creates a benchmark function.
*
Expand All @@ -38,17 +53,7 @@ var nanminabs = require( './../lib/ndarray.js' );
* @returns {Function} benchmark function
*/
function createBenchmark( len ) {
var x;
var i;

x = [];
for ( i = 0; i < len; i++ ) {
if ( randu() < 0.2 ) {
x.push( NaN );
} else {
x.push( ( randu()*20.0 ) - 10.0 );
}
}
var x = filledarrayBy( len, 'generic', rand );
return benchmark;

function benchmark( b ) {
Expand Down
32 changes: 14 additions & 18 deletions lib/node_modules/@stdlib/stats/base/nanminabs/docs/repl.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@

{{alias}}( N, x, stride )
{{alias}}( N, x, strideX )
Computes the minimum absolute value of a strided array, ignoring `NaN`
values.

The `N` and `stride` parameters determine which elements in `x` are accessed
at runtime.
The `N` and stride parameters determine which elements in the strided array
are accessed at runtime.

Indexing is relative to the first index. To introduce an offset, use a typed
array view.
Expand All @@ -19,8 +19,8 @@
x: Array<number>|TypedArray
Input array.

stride: integer
Index increment.
strideX: integer
Stride length.

Returns
-------
Expand All @@ -34,22 +34,19 @@
> {{alias}}( x.length, x, 1 )
1.0

// Using `N` and `stride` parameters:
// Using `N` and stride parameters:
> x = [ -2.0, 1.0, 1.0, -5.0, 2.0, -1.0, NaN, NaN ];
> var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 );
> var stride = 2;
> {{alias}}( N, x, stride )
> {{alias}}( 4, x, 2 )
1.0

// Using view offsets:
> var x0 = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0, NaN, NaN ] );
> var x1 = new {{alias:@stdlib/array/float64}}( x0.buffer, x0.BYTES_PER_ELEMENT*1 );
> N = {{alias:@stdlib/math/base/special/floor}}( x0.length / 2 );
> stride = 2;
> {{alias}}( N, x1, stride )
> {{alias}}( 4, x1, 2 )
1.0

{{alias}}.ndarray( N, x, stride, offset )

{{alias}}.ndarray( N, x, strideX, offsetX )
Computes the minimum absolute value of a strided array, ignoring `NaN`
values and using alternative indexing semantics.

Expand All @@ -65,10 +62,10 @@
x: Array<number>|TypedArray
Input array.

stride: integer
Index increment.
strideX: integer
Stride length.

offset: integer
offsetX: integer
Starting index.

Returns
Expand All @@ -85,8 +82,7 @@

// Using offset parameter:
> var x = [ 1.0, -2.0, 3.0, 2.0, 5.0, -1.0, NaN, NaN ];
> var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 );
> {{alias}}.ndarray( N, x, 2, 1 )
> {{alias}}.ndarray( 4, x, 2, 1 )
1.0

See Also
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@

/// <reference types="@stdlib/types"/>

import { NumericArray } from '@stdlib/types/array';
import { NumericArray, Collection, AccessorArrayLike } from '@stdlib/types/array';

/**
* Input array.
*/
type InputArray = NumericArray | Collection<number> | AccessorArrayLike<number>;

/**
* Interface describing `nanminabs`.
Expand All @@ -31,7 +36,7 @@ interface Routine {
*
* @param N - number of indexed elements
* @param x - input array
* @param stride - stride length
* @param strideX - stride length
* @returns minimum absolute value
*
* @example
Expand All @@ -40,15 +45,15 @@ interface Routine {
* var v = nanminabs( x.length, x, 1 );
* // returns 1.0
*/
( N: number, x: NumericArray, stride: number ): number;
( N: number, x: InputArray, strideX: number ): number;

/**
* Computes the minimum absolute value of a strided array, ignoring `NaN` values and using alternative indexing semantics.
*
* @param N - number of indexed elements
* @param x - input array
* @param stride - stride length
* @param offset - starting index
* @param strideX - stride length
* @param offsetX - starting index
* @returns minimum absolute value
*
* @example
Expand All @@ -57,15 +62,15 @@ interface Routine {
* var v = nanminabs.ndarray( x.length, x, 1, 0 );
* // returns 1.0
*/
ndarray( N: number, x: NumericArray, stride: number, offset: number ): number;
ndarray( N: number, x: InputArray, strideX: number, offsetX: number ): number;
}

/**
* Computes the minimum absolute value of a strided array, ignoring `NaN` values.
*
* @param N - number of indexed elements
* @param x - input array
* @param stride - stride length
* @param strideX - stride length
* @returns minimum absolute value
*
* @example
Expand Down
Loading