feat: refactor and add protocol support to `stats/base/nanminabs` #6345

Kaushikgtm · 2025-03-24T17:24:51Z

Resolves #5661.

Description

What is the purpose of this pull request?

This pull request:

{{TODO: add description describing what this pull request does}}

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: refactor and add protocol support to stats/base/nanminabs #5661.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

stdlib-bot · 2025-03-24T17:25:02Z

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

Please read our contributing guidelines.
Update your pull request description to include this checked box:

- [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

The developer's certificate of origin
Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

stdlib-bot · 2025-03-24T17:25:56Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/nanminabs	$\color{green}297/297$ $\color{green}+100.00\%$	$\color{green}38/38$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}297/297$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Kaushikgtm · 2025-03-24T17:31:45Z

@aayush0325 please review

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Kaushikgtm · 2025-03-25T18:07:40Z

@kgryte, please review this PR.

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

gururaj1512 · 2025-06-04T14:06:12Z

/stdlib merge

stdlib-bot · 2025-06-04T14:08:36Z

/stdlib merge

@gururaj1512, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

Signed-off-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Signed-off-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/stats/base/nanminabs/test/test.nanminabs.js

Signed-off-by: Athan <kgryte@gmail.com>

kgryte

LGTM

Kaushikgtm added 12 commits March 24, 2025 22:23

Create accessors.js

1e88fed

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update nanminabs.js

6ce5e2f

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update ndarray.js

cd1cffc

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update test.nanminabs.js

5288bf3

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update test.ndarray.js

5485348

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update README.md

53c7a60

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update benchmark.js

2212af9

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update benchmark.ndarray.js

1d6b606

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update index.d.ts

f45c5c7

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update test.ts

da46e37

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update index.js

1ab7879

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update repl.txt

178e066

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

stdlib-bot added Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Mar 24, 2025

Kaushikgtm added 12 commits March 25, 2025 20:20

Update accessors.js

0ab9225

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update test.nanminabs.js

3700f20

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update accessors.js

857973a

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update accessors.js

6230aa3

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update nanminabs.js

9807141

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update repl.txt

a47a21e

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update repl.txt

9274896

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update README.md

8b9cba8

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update README.md

b5b1523

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update README.md

e80b90e

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update README.md

612e0a8

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update repl.txt

a672185

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Kaushikgtm added 4 commits March 25, 2025 23:14

Update repl.txt

7fbca71

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update repl.txt

433a6e6

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update repl.txt

fef60be

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update repl.txt

1a99c85

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Kaushikgtm added 2 commits March 26, 2025 13:15

Update test.ndarray.js

2fca3d1

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update test.ndarray.js

bb1f043

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 4, 2025

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 4, 2025

gururaj1512 and others added 8 commits June 4, 2025 19:44

Merge branch 'develop' into Kaushikgtm-nanminabs

590b702

Signed-off-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com>

Update repl.txt

8308325

Signed-off-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com>

kgryte changed the title ~~feat: refactor and add protocol support to stats/base/nanminabs #5661~~ feat: refactor and add protocol support to stats/base/nanminabs Jun 5, 2025

kgryte reviewed Jun 5, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/nanminabs/test/test.nanminabs.js Outdated Show resolved Hide resolved

kgryte reviewed Jun 5, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/nanminabs/test/test.nanminabs.js Outdated Show resolved Hide resolved

kgryte added 3 commits June 4, 2025 21:41

Apply suggestions from code review

80a3662

Signed-off-by: Athan <kgryte@gmail.com>

test: update descriptions

d0d90c1

Signed-off-by: Athan <kgryte@gmail.com>

test: update descriptions

8d23f21

Signed-off-by: Athan <kgryte@gmail.com>

kgryte approved these changes Jun 5, 2025

View reviewed changes

kgryte removed the Needs Review A pull request which needs code review. label Jun 5, 2025

kgryte merged commit 5f8c1b8 into stdlib-js:develop Jun 5, 2025
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: refactor and add protocol support to `stats/base/nanminabs` #6345

feat: refactor and add protocol support to `stats/base/nanminabs` #6345

Uh oh!

Kaushikgtm commented Mar 24, 2025 •

edited

Loading

Uh oh!

stdlib-bot commented Mar 24, 2025

Uh oh!

stdlib-bot commented Mar 24, 2025 •

edited

Loading

Uh oh!

Kaushikgtm commented Mar 24, 2025

Uh oh!

Kaushikgtm commented Mar 25, 2025

Uh oh!

gururaj1512 commented Jun 4, 2025

Uh oh!

stdlib-bot commented Jun 4, 2025

Uh oh!

Uh oh!

Uh oh!

kgryte left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat: refactor and add protocol support to stats/base/nanminabs #6345

feat: refactor and add protocol support to stats/base/nanminabs #6345

Uh oh!

Conversation

Kaushikgtm commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Mar 24, 2025

Uh oh!

stdlib-bot commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Kaushikgtm commented Mar 24, 2025

Uh oh!

Kaushikgtm commented Mar 25, 2025

Uh oh!

gururaj1512 commented Jun 4, 2025

Uh oh!

stdlib-bot commented Jun 4, 2025

Uh oh!

Uh oh!

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

feat: refactor and add protocol support to `stats/base/nanminabs` #6345

feat: refactor and add protocol support to `stats/base/nanminabs` #6345

Kaushikgtm commented Mar 24, 2025 •

edited

Loading

stdlib-bot commented Mar 24, 2025 •

edited

Loading