-
-
Notifications
You must be signed in to change notification settings - Fork 835
feat: add accessor protocol support and refactor stats/base/nanvarianceyc
#6143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add accessor protocol support and refactor stats/base/nanvarianceyc
#6143
Conversation
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/stats/base/nanvarianceyc/docs/repl.txt
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/nanvarianceyc/docs/repl.txt
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/nanvarianceyc/docs/repl.txt
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/stats/base/nanvarianceyc/docs/repl.txt
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/stats/base/nanvarianceyc/lib/nanvarianceyc.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
lib/node_modules/@stdlib/stats/base/nanvarianceyc/lib/ndarray.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for opening a relatively clean PR. Only had a few nits that I went ahead and fixed.
stats/base/nanvarianceyc
stats/base/nanvarianceyc
Signed-off-by: Athan <kgryte@gmail.com>
Hi @kgryte, Thank you for quick review and fixing those nits. I'll make sure to avoid those mistakes in the future. |
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves #5678 .
Description
This pull request:
accessors.js
.nanvarianceyc.js
.ndarray.js
.Related Issues
This pull request:
stats/base/nanvarianceyc
#5678Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers