Skip to content

feat: migrate utils/thunk to function/thunk #5458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

Neerajpathak07
Copy link
Member

Resolves #5445.

Description

What is the purpose of this pull request?

This pull request:

  • migrates utils/thunk to function/thunk

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

This commit removes the `thunk` symbol from the `@stdlib/utils`
namespace due to a package migration.

BREAKING CHANGE: remove `thunk`

To migrate, users should access the same symbol via the
`@stdlib/function` namespace.
This commit removes `@stdlib/utils/thunk` in favor of
`@stdlib/function/thunk`.

BREAKING CHANGE: remove `utils/thunk`

To migrate, users should update their require/import paths to use
`@stdlib/function/thunk` which provides the same API and implementation.

Ref: stdlib-js#5445
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
function/thunk $\color{green}115/115$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}115/115$
$\color{green}+100.00\%$
utils $\color{green}1945/1945$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}1945/1945$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review February 26, 2025 07:06
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 26, 2025
@Neerajpathak07
Copy link
Member Author

@kgryte Looks about right now??

@kgryte kgryte added release: Major Breaking change requiring a new major release. and removed Needs Review A pull request which needs code review. labels Feb 26, 2025
@kgryte
Copy link
Member

kgryte commented Feb 26, 2025

Looks about right now??

Yes, it does! Thank you for following the guide.

@kgryte kgryte merged commit b6624d0 into stdlib-js:develop Feb 26, 2025
44 checks passed
kgryte added a commit that referenced this pull request Feb 27, 2025
Ref: #5458

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: Major Breaking change requiring a new major release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: migrate utils/thunk to function/thunk
3 participants