Skip to content

feat: add C implementation for stats/base/dists/gumbel/skewness #5222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat: add C implementation for stats/base/dists/gumbel/skewness #5222

wants to merge 2 commits into from

Conversation

kartikk61
Copy link

Resolves #3654 .

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for @stdlib/stats/base/dists/gumbel/skewness along with relevant tests, benchmarks and examples

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@kartikk61
feat: add C implementation for stats/base/dists/gumbel/skewness
8f8b360 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Feb 15, 2025
stdlib-bot
stdlib-bot reviewed Feb 15, 2025
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@kartikk61
fixup! feat: add C implementation for stats/base/dists/gumbel/skewness
be347fd 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/gumbel/skewness $\color{green}183/183$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}183/183$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

0PrashantYadav0
0PrashantYadav0 reviewed Feb 23, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/gumbel/skewness/benchmark/benchmark.js
mu[ i ] = uniform( -50.0, 50.0 );
beta[ i ] = uniform( EPS, 20.0 );
mu[ i ] = ( randu() * 100.0 ) - 50.0;
beta[ i ] = ( randu() * 20.0 ) + EPS;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes need to be reversed.

lib/node_modules/@stdlib/stats/base/dists/gumbel/skewness/benchmark/benchmark.native.js
mu = new Float64Array( len );
beta = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
mu[ i ] = ( randu()*100.0 ) - 50.0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to current convention i think you need to use uniform function to generate these.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mu[ i ] = ( randu()*100.0 ) - 50.0;
mu[ i ] = uniform( -50.0, 50.0 );
beta[ i ] = uniform( EPS, 20.0 );

lib/node_modules/@stdlib/stats/base/dists/gumbel/skewness/test/test.native.js
t.equal( y, expected[i], 'mu:'+mu[i]+', beta: '+beta[i]+', y: '+y+', expected: '+expected[i] );
} else {
delta = abs( y - expected[ i ] );
tol = 2.0 * EPS * abs( expected[ i ] );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check for tolerance value here.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 7, 2025
@Planeshifter
Copy link
Member

Thank you so much for your contribution and the effort you put into this PR. We ended up merging a different PR (link to PR) that addressed the same issue, so I am closing this one.

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@0PrashantYadav0 0PrashantYadav0 0PrashantYadav0 left review comments

Assignees
No one assigned
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/gumbel/skewness
4 participants
@kartikk61 @stdlib-bot @Planeshifter @0PrashantYadav0