Skip to content

feat: add C implementation for stats/base/dists/gumbel/skewness #4650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Apr 3, 2025
Merged

feat: add C implementation for stats/base/dists/gumbel/skewness #4650

merged 21 commits into from
Apr 3, 2025

Conversation

ShabiShett07
Copy link
Contributor

Resolves #3613.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 8, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 8, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/gumbel/skewness $\color{green}180/180$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}180/180$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@ShabiShett07
fix: package.json
12b1c6c 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 8, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 8, 2025
@ShabiShett07
Copy link
Contributor Author

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 8, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 8, 2025
@Planeshifter Planeshifter self-requested a review April 2, 2025 00:22
Planeshifter
Planeshifter requested changes Apr 2, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShabiShett07!

Left a few comments; the README.md file will also have to be updated.

@ShabiShett07 @Planeshifter
fix: update native.js
8797f3d 
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Apr 2, 2025
ShabiShett07 and others added 5 commits April 2, 2025 09:23
@ShabiShett07 @Planeshifter
fix: removed multiple examples
a0ab54c 
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07 @Planeshifter
fix: change example inputs
8e1057e 
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07 @Planeshifter
fix: change benchmark inputs
6ac5517 
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07 @Planeshifter
fix: main.c header files
1d19d0c 
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
fix: formayt errors
c118bc9
@ShabiShett07
Copy link
Contributor Author

@Planeshifter, I have resolved all the conversations.

@Planeshifter
Copy link
Member

@ShabiShett07 Thank you! Only missing thing now is the C section for the README.md file.

Planeshifter
Planeshifter requested changes Apr 2, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md looking good now, but just noticed we can precompute a constant.

ShabiShett07 and others added 3 commits April 2, 2025 22:14
@ShabiShett07 @Planeshifter
chore: change variable format
9b207e6 
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07 @Planeshifter
chore: change variable format
e0190fb 
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
chore: declare variable
e8e9595 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@ShabiShett07
Copy link
Contributor Author

@Planeshifter, Sorry there are some errors I will fix it in some minutes

@ShabiShett07
chore: assigned constant value
1e309d4 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@ShabiShett07
Copy link
Contributor Author

@Planeshifter, ready for review

ShabiShett07 and others added 2 commits April 2, 2025 22:42
@ShabiShett07
Merge branch 'develop' into feature/gumbel/skewness
5bcb472 
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
@ShabiShett07
fix: lint error
912442a 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter changed the title feat: add /stats/base/dists/gumbel/skewness feat: add C implementation for stats/base/dists/gumbel/skewness Apr 3, 2025
Planeshifter
Planeshifter previously approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for so quickly addressing all comments! Let's merge this PR shortly.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 3, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 3, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/gumbel/skewness`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4650
Closes: https://github.com/stdlib-js/stdlib/issues/3613

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>
Co-authored-by: ShabiShett07 <shabishetty07@gmail.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Shabareesh Shetty <139731143+ShabiShett07@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter
fix: add missing include
6c9af0a 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
style: add empty line
055387c 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter merged commit 63ff101 into stdlib-js:develop Apr 3, 2025
12 checks passed
@Planeshifter Planeshifter mentioned this pull request Apr 19, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/frechet/quantile
3 participants
@ShabiShett07 @stdlib-bot @Planeshifter