Skip to content

feat: add array/base/mskunary4d #3208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 25, 2024

Conversation

AbhijitRaut04
Copy link
Contributor

Resolves #3176 .

Description

What is the purpose of this pull request?

This pull request:

  • Implemented mskunary4d functionality for four-dimensional array

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@AbhijitRaut04 AbhijitRaut04 changed the title Feat/mskunary4d feat: add implementation for array/base/mskunary4d Nov 21, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 21, 2024

Coverage Report

Package Statements Branches Functions Lines
array/base/mskunary4d $\color{green}167/167$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}167/167$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities. labels Nov 22, 2024
@kgryte kgryte changed the title feat: add implementation for array/base/mskunary4d feat: add array/base/mskunary4d Nov 22, 2024
@AbhijitRaut04 AbhijitRaut04 deleted the feat/mskunary4d branch November 25, 2024 07:28
@AbhijitRaut04 AbhijitRaut04 restored the feat/mskunary4d branch November 25, 2024 07:29
@AbhijitRaut04 AbhijitRaut04 reopened this Nov 25, 2024
@AbhijitRaut04
Copy link
Contributor Author

No I accidently deleted the branch

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @AbhijitRaut04!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Nov 25, 2024
@kgryte kgryte merged commit 28db4f2 into stdlib-js:develop Nov 25, 2024
12 checks passed
pranav-1720 pushed a commit to pranav-1720/stdlib that referenced this pull request Nov 25, 2024
PR-URL: stdlib-js#3208
Closes: stdlib-js#3176
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
@AbhijitRaut04 AbhijitRaut04 deleted the feat/mskunary4d branch December 26, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add array/base/mskunary4d
3 participants