-
-
Notifications
You must be signed in to change notification settings - Fork 833
feat: add blas/base/ssymv
#2305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@aman-095 I've done a partial review and refactor: benchmarks, docs, examples, and |
Sure, Athan will review those and apply changes elsewhere. |
The test fixtures were not generated by Julia and so should not be in the Julia directory.
@aman-095 One thing which is missing from the tests are column-major variants. All test fixtures atm are row-major. |
@aman-095 We also need to add assertion tests in order to get 100% code coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @aman-095.
For the other related PRs, you'll want to compute the diff between your last commit and the current state. That will help inform you as to what changes need to be propagated to ssbmv
and others.
Note that I went ahead and added tests for edge cases, assertions, and column-major. Those will also need to be added to other PRs.
Description
This RFC proposes to add a routine to perform one of the matrix-vector operations
y = alpha*A*x + beta*y
where alpha and beta are scalars, x and y are n element vectors and A is an n by n symmetric matrix as defined in BLAS Level 2 routines. Specifically adding@stdlib/blas/base/ssymv
is proposed.Related Issues
None.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers