Skip to content

Commit 4594ac2

Browse files
committed
chore: apply review changes
1 parent 71090c4 commit 4594ac2

File tree

12 files changed

+162
-254
lines changed

12 files changed

+162
-254
lines changed

lib/node_modules/@stdlib/blas/base/ssymv/README.md

Lines changed: 28 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ limitations under the License.
2020

2121
# ssymv
2222

23-
> Perform one of the matrix-vector operations `y = alpha*A*x + beta*y` where alpha and beta are scalars, x and y are n element vectors and A is an n by n symmetric matrix.
23+
> Perform one of the matrix-vector operations `y = α*A*x + β*y` where α and β are scalars, x and y are n element vectors and A is an n by n symmetric matrix.
2424
2525
<section class = "usage">
2626

@@ -30,41 +30,32 @@ limitations under the License.
3030
var ssymv = require( '@stdlib/blas/base/ssymv' );
3131
```
3232

33-
#### ssymv( ord, uplo, N, a, A, LDA, x, sx, b, y, sy )
33+
#### ssymv( ord, uplo, N, α, A, LDA, x, sx, β, y, sy )
3434

35-
Performs one of the matrix-vector operations `y = alpha*A*x + beta*y` where alpha and beta are scalars, x and y are n element vectors and A is an n by n symmetric matrix.
35+
Performs one of the matrix-vector operations `y = α*A*x + β*y` where α and β are scalars, x and y are n element vectors and A is an n by n symmetric matrix.
3636

3737
```javascript
3838
var Float32Array = require( '@stdlib/array/float32' );
3939

40-
var uplo = 'L';
41-
var order = 'row-major';
42-
43-
var N = 3;
44-
var lda = 3;
45-
46-
var alpha = 1.0;
47-
var beta = 0.0;
48-
49-
var A = new Float32Array( [ 1.0, 0.0, 0.0, 2.0, 4.0, 0.0, 3.0, 5.0, 6.0 ] );
40+
var A = new Float32Array( [ 1.0, 0.0, 0.0, 0.0, 2.0, 0.0, 0.0, 0.0, 3.0 ] );
5041
var x = new Float32Array( [ 1.0, 1.0, 1.0 ] );
5142
var y = new Float32Array( [ 0.0, 0.0, 0.0 ] );
5243

53-
ssymv( order, uplo, N, alpha, A, lda, x, 1, beta, y, 1 );
54-
// y => <Float32Array>[ 6.0, 11.0, 14.0 ]
44+
ssymv( 'row-major', 'lower', 3, 1.0, A, 3, x, 1, 0.0, y, 1 );
45+
// y => <Float32Array>[ 1.0, 2.0, 3.0 ]
5546
```
5647

5748
The function has the following parameters:
5849

5950
- **ord**: storage layout.
6051
- **uplo**: specifies the operation to be performed.
6152
- **N**: specifies the order of the matrix `A`.
62-
- **a**: scalar constant.
53+
- **α**: scalar constant.
6354
- **A**: matrix of coefficients [`Float32Array`][mdn-float32array].
6455
- **lda**: stride of the first dimension of `A` (leading dimension of `A`).
6556
- **x**: input [`Float32Array`][mdn-float32array].
6657
- **sx**: index increment for `x`.
67-
- **b**: scalar constant.
58+
- **β**: scalar constant.
6859
- **y**: output [`Float32Array`][mdn-float32array].
6960
- **sy**: index increment for `y`.
7061

@@ -74,21 +65,12 @@ perform one of the matrix-vector operations starting from the second index of `x
7465
```javascript
7566
var Float32Array = require( '@stdlib/array/float32' );
7667

77-
var uplo = 'U';
78-
var order = 'row-major';
79-
80-
var N = 3;
81-
var lda = 3;
82-
83-
var alpha = 2.0;
84-
var beta = 1.0;
85-
86-
var A = new Float32Array( [ 1.0, 2.0, 3.0, 0.0, 4.0, 5.0, 0.0, 0.0, 6.0 ] );
68+
var A = new Float32Array( [ 1.0, 0.0, 0.0, 0.0, 2.0, 0.0, 0.0, 0.0, 3.0 ] );
8769
var x = new Float32Array( [ 1.0, 2.0, 3.0 ] );
8870
var y = new Float32Array( [ 1.0, 2.0, 3.0 ] );
8971

90-
ssymv( order, uplo, N, alpha, A, lda, x, -1, beta, y, 1 );
91-
// y => <Float32Array>[ 21.0, 40.0, 53.0 ]
72+
ssymv( 'row-major', 'upper', 3, 2.0, A, 3, x, -1, 1.0, y, 1 );
73+
// y => <Float32Array>[ 7.0, 10.0, 9.0 ]
9274
```
9375

9476
Note that indexing is relative to the first index. To introduce an offset, use [`typed array`][mdn-typed-array] views.
@@ -101,38 +83,29 @@ var Float32Array = require( '@stdlib/array/float32' );
10183
// Initial arrays...
10284
var x0 = new Float32Array( [ 1.0, 1.0, 1.0, 1.0 ] );
10385
var y0 = new Float32Array( [ 1.0, 1.0, 1.0, 1.0 ] );
104-
var A = new Float32Array( [ 1.0, 2.0, 3.0, 0.0, 4.0, 5.0, 0.0, 0.0, 6.0 ] );
86+
var A = new Float32Array( [ 1.0, 0.0, 0.0, 0.0, 2.0, 0.0, 0.0, 0.0, 3.0 ] );
10587

10688
// Create offset views...
10789
var x1 = new Float32Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element
108-
var y1 = new Float32Array( y0.buffer, y0.BYTES_PER_ELEMENT*1 ); // start at 1st element
90+
var y1 = new Float32Array( y0.buffer, y0.BYTES_PER_ELEMENT*1 ); // start at 2nd element
10991

110-
ssymv( 'row-major', 'U', 3, 1.0, A, 3, x1, -1, 1.0, y1, -1 );
111-
// y0 => <Float32Array>[ 1.0, 15.0, 12.0, 7.0 ]
92+
ssymv( 'row-major', 'upper', 3, 1.0, A, 3, x1, -1, 1.0, y1, -1 );
93+
// y0 => <Float32Array>[ 1.0, 4.0, 3.0, 2.0 ]
11294
```
11395

114-
#### ssymv.ndarray( ord, uplo, N, a, A, LDA, x, sx, ox, b, y, sy, oy )
96+
#### ssymv.ndarray( ord, uplo, N, α, A, LDA, x, sx, ox, β, y, sy, oy )
11597

116-
Performs one of the matrix-vector operations `y = alpha*A*x + beta*y` where alpha and beta are scalars, x and y are n element vectors and A is an n by n symmetric matrix using alternative indexing semantics.
98+
Performs one of the matrix-vector operations `y = α*A*x + β*y` where α and β are scalars, x and y are n element vectors and A is an n by n symmetric matrix using alternative indexing semantics.
11799

118100
```javascript
119101
var Float32Array = require( '@stdlib/array/float32' );
120102

121-
var uplo = 'U';
122-
var order = 'row-major';
123-
124-
var N = 3;
125-
var lda = 3;
126-
127-
var alpha = 2.0;
128-
var beta = 1.0;
129-
130-
var A = new Float32Array( [ 1.0, 2.0, 3.0, 0.0, 4.0, 5.0, 0.0, 0.0, 6.0 ] );
103+
var A = new Float32Array( [ 1.0, 0.0, 0.0, 0.0, 2.0, 0.0, 0.0, 0.0, 3.0 ] );
131104
var x = new Float32Array( [ 1.0, 2.0, 3.0 ] );
132105
var y = new Float32Array( [ 1.0, 2.0, 3.0 ] );
133106

134-
ssymv.ndarray( order, uplo, N, alpha, A, lda, x, -1, 2, beta, y, 1, 0 );
135-
// y => <Float32Array>[ 21.0, 40.0, 53.0 ]
107+
ssymv.ndarray( 'row-major', 'upper', 3, 2.0, A, 3, x, -1, 2, 1.0, y, 1, 0 );
108+
// y => <Float32Array>[ 7.0, 10.0, 9.0 ]
136109
```
137110

138111
The function has the following additional parameters:
@@ -145,21 +118,12 @@ While [`typed array`][mdn-typed-array] views mandate a view offset based on the
145118
```javascript
146119
var Float32Array = require( '@stdlib/array/float32' );
147120

148-
var uplo = 'L';
149-
var order = 'row-major';
150-
151-
var N = 3;
152-
var lda = 3;
153-
154-
var alpha = 1.0;
155-
var beta = 0.0;
156-
157-
var A = new Float32Array( [ 1.0, 0.0, 0.0, 2.0, 4.0, 0.0, 3.0, 5.0, 6.0 ] );
121+
var A = new Float32Array( [ 1.0, 0.0, 0.0, 0.0, 2.0, 0.0, 0.0, 0.0, 3.0 ] );
158122
var x = new Float32Array( [ 1.0, 1.0, 1.0 ] );
159-
var y = new Float32Array( [ 0.0, 0.0, 0.0 ] );
123+
var y = new Float32Array( [ 1.0, 1.0, 1.0 ] );
160124

161-
ssymv.ndarray( order, uplo, N, alpha, A, lda, x, 1, 0, beta, y, 1, 0 );
162-
// y => <Float32Array>[ 6.0, 11.0, 14.0 ]
125+
ssymv.ndarray( 'row-major', 'lower', 3, 1.0, A, 3, x, -1, 2, 1.0, y, -1, 2 );
126+
// y => <Float32Array>[ 4.0, 3.0, 2.0 ]
163127
```
164128

165129
</section>
@@ -184,26 +148,20 @@ ssymv.ndarray( order, uplo, N, alpha, A, lda, x, 1, 0, beta, y, 1, 0 );
184148

185149
```javascript
186150
var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
151+
var ones = require( '@stdlib/array/ones' );
187152
var ssymv = require( '@stdlib/blas/base/ssymv' );
188153

189154
var opts = {
190155
'dtype': 'float32'
191156
};
192157

193-
var uplo = 'U';
194-
195158
var N = 3;
196-
var lda = 3;
197-
198-
var alpha = 1;
199-
var beta = 1;
200-
201-
var A = discreteUniform( N*N, 0, 255, opts );
159+
var A = ones( N*N, opts.dtype );
202160

203161
var x = discreteUniform( N, 0, 255, opts );
204162
var y = discreteUniform( N, 0, 255, opts );
205163

206-
ssymv.ndarray( 'row-major', uplo, N, alpha, A, lda, x, 1, 0, beta, y, 1, 0 );
164+
ssymv.ndarray( 'row-major', 'upper', N, 1.0, A, N, x, 1, 0, 1.0, y, 1, 0 );
207165
console.log( y );
208166

209167
```
@@ -235,7 +193,7 @@ console.log( y );
235193
### Usage
236194

237195
```c
238-
#include "stdlib/blas/base/ssymv.h"
196+
TODO
239197
```
240198

241199
#### TODO

lib/node_modules/@stdlib/blas/base/ssymv/benchmark/benchmark.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
var bench = require( '@stdlib/bench' );
2424
var uniform = require( '@stdlib/random/array/uniform' );
2525
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
26+
var ones = require( '@stdlib/array/ones' );
2627
var pow = require( '@stdlib/math/base/special/pow' );
2728
var floor = require( '@stdlib/math/base/special/floor' );
2829
var pkg = require( './../package.json' ).name;
@@ -48,7 +49,7 @@ var options = {
4849
function createBenchmark( N ) {
4950
var x = uniform( N, -10.0, 10.0, options );
5051
var y = uniform( N, -10.0, 10.0, options );
51-
var A = uniform( N*N, -10.0, 10.0, options );
52+
var A = ones( N*N, options.dtype );
5253
return benchmark;
5354

5455
/**

lib/node_modules/@stdlib/blas/base/ssymv/benchmark/benchmark.ndarray.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
var bench = require( '@stdlib/bench' );
2424
var uniform = require( '@stdlib/random/array/uniform' );
2525
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
26+
var ones = require( '@stdlib/array/ones' );
2627
var pow = require( '@stdlib/math/base/special/pow' );
2728
var floor = require( '@stdlib/math/base/special/floor' );
2829
var pkg = require( './../package.json' ).name;
@@ -48,7 +49,7 @@ var options = {
4849
function createBenchmark( N ) {
4950
var x = uniform( N, -10.0, 10.0, options );
5051
var y = uniform( N, -10.0, 10.0, options );
51-
var A = uniform( N*N, -10.0, 10.0, options );
52+
var A = ones( N*N, options.dtype );
5253
return benchmark;
5354

5455
/**
@@ -98,7 +99,7 @@ function main() {
9899
for ( i = min; i <= max; i++ ) {
99100
N = floor( pow( pow( 10, i ), 1.0/2.0 ) );
100101
f = createBenchmark( N );
101-
bench( pkg+':size='+(N*N), f );
102+
bench( pkg+':ndarray:size='+(N*N), f );
102103
}
103104
}
104105

lib/node_modules/@stdlib/blas/base/ssymv/docs/types/index.d.ts

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,12 @@ interface Routine {
5151
* @example
5252
* var Float32Array = require( '@stdlib/array/float32' );
5353
*
54-
* var A = new Float32Array( [ 1.0, 2.0, 3.0, 2.0, 4.0, 5.0, 3.0, 5.0, 6.0 ] );
54+
* var A = new Float32Array( [ 1.0, 0.0, 0.0, 0.0, 2.0, 0.0, 0.0, 0.0, 3.0 ] );
5555
* var x = new Float32Array( [ 1.0, 1.0, 1.0 ] );
5656
* var y = new Float32Array( [ 0.0, 0.0, 0.0 ] );
5757
*
5858
* ssymv( 'row-major', 'lower', 3, 1.0, A, 3, x, 1, 0.0, y, 1 );
59-
* // y => <Float32Array>[ 6.0, 11.0, 14.0 ]
59+
* // y => <Float32Array>[ 1.0, 2.0, 3.0 ]
6060
*/
6161
( order: Order, uplo: UPLO, N: number, alpha: number, A: Float32Array, LDA: number, x: Float32Array, strideX: number, beta: number, y: Float32Array, strideY: number ): Float32Array;
6262

@@ -81,12 +81,12 @@ interface Routine {
8181
* @example
8282
* var Float32Array = require( '@stdlib/array/float32' );
8383
*
84-
* var A = new Float32Array( [ 1.0, 2.0, 3.0, 2.0, 4.0, 5.0, 3.0, 5.0, 6.0 ] );
84+
* var A = new Float32Array( [ 1.0, 0.0, 0.0, 0.0, 2.0, 0.0, 0.0, 0.0, 3.0 ] );
8585
* var x = new Float32Array( [ 1.0, 1.0, 1.0 ] );
8686
* var y = new Float32Array( [ 0.0, 0.0, 0.0 ] );
8787
*
8888
* ssymv.ndarray( 'row-major', 'lower', 3, 1.0, A, 3, x, 1, 0, 0.0, y, 1, 0 );
89-
* // y => <Float32Array>[ 6.0, 11.0, 14.0 ]
89+
* // y => <Float32Array>[ 1.0, 2.0, 3.0 ]
9090
*/
9191
ndarray( order: Order, uplo: UPLO, N: number, alpha: number, A: Float32Array, LDA: number, x: Float32Array, strideX: number, offsetX: number, beta: number, y: Float32Array, strideY: number, offsetY: number ): Float32Array;
9292
}
@@ -110,22 +110,22 @@ interface Routine {
110110
* @example
111111
* var Float32Array = require( '@stdlib/array/float32' );
112112
*
113-
* var A = new Float32Array( [ 1.0, 2.0, 3.0, 2.0, 4.0, 5.0, 3.0, 5.0, 6.0 ] );
114-
* var x = new Float32Array( [ 1.0, 1.0, 1.0 ] );
115-
* var y = new Float32Array( [ 0.0, 0.0, 0.0 ] );
113+
* var A = new Float32Array( [ 1.0, 0.0, 0.0, 0.0, 2.0, 0.0, 0.0, 0.0, 3.0 ] );
114+
* var x = new Float32Array( [ 1.0, 2.0, 3.0 ] );
115+
* var y = new Float32Array( [ 1.0, 2.0, 3.0 ] );
116116
*
117-
* ssymv( 'row-major', 'lower', 3, 1.0, A, 3, x, 1, 0.0, y, 1 );
118-
* // y => <Float32Array>[ 6.0, 11.0, 14.0 ]
117+
* ssymv( 'row-major', 'upper', 3, 2.0, A, 3, x, 1, 1.0, y, 2 );
118+
* // y => <Float32Array>[ 3.0, 2.0, 11.0 ]
119119
*
120120
* @example
121121
* var Float32Array = require( '@stdlib/array/float32' );
122122
*
123-
* var A = new Float32Array( [ 1.0, 2.0, 3.0, 2.0, 4.0, 5.0, 3.0, 5.0, 6.0 ] );
124-
* var x = new Float32Array( [ 1.0, 1.0, 1.0 ] );
125-
* var y = new Float32Array( [ 0.0, 0.0, 0.0 ] );
123+
* var A = new Float32Array( [ 1.0, 0.0, 0.0, 0.0, 2.0, 0.0, 0.0, 0.0, 3.0 ] );
124+
* var x = new Float32Array( [ 1.0, 2.0, 3.0 ] );
125+
* var y = new Float32Array( [ 1.0, 2.0, 3.0 ] );
126126
*
127-
* ssymv.ndarray( 'row-major', 'lower', 3, 1.0, A, 3, x, 1, 0, 0.0, y, 1, 0 );
128-
* // y => <Float32Array>[ 6.0, 11.0, 14.0 ]
127+
* ssymv.ndarray( 'row-major', 'upper', 3, 2.0, A, 3, x, 1, 0, 1.0, y, 2, 0 );
128+
* // y => <Float32Array>[ 3.0, 2.0, 11.0 ]
129129
*/
130130
declare var ssymv: Routine;
131131

lib/node_modules/@stdlib/blas/base/ssymv/lib/index.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,23 +27,23 @@
2727
* var Float32Array = require( '@stdlib/array/float32' );
2828
* var ssymv = require( '@stdlib/blas/base/ssymv' );
2929
*
30-
* var A = new Float32Array( [ 1.0, 2.0, 3.0, 2.0, 4.0, 5.0, 3.0, 5.0, 6.0 ] );
30+
* var A = new Float32Array( [ 1.0, 0.0, 0.0, 0.0, 2.0, 0.0, 0.0, 0.0, 3.0 ] );
3131
* var x = new Float32Array( [ 1.0, 1.0, 1.0 ] );
3232
* var y = new Float32Array( [ 0.0, 0.0, 0.0 ] );
3333
*
3434
* ssymv( 'row-major', 'lower', 3, 1.0, A, 3, x, 1, 0.0, y, 1 );
35-
* // y => <Float32Array>[ 6.0, 11.0, 14.0 ]
35+
* // y => <Float32Array>[ 1.0, 2.0, 3.0 ]
3636
*
3737
* @example
3838
* var Float32Array = require( '@stdlib/array/float32' );
3939
* var ssymv = require( '@stdlib/blas/base/ssymv' );
4040
*
41-
* var A = new Float32Array( [ 1.0, 2.0, 3.0, 2.0, 4.0, 5.0, 3.0, 5.0, 6.0 ] );
41+
* var A = new Float32Array( [ 1.0, 0.0, 0.0, 0.0, 2.0, 0.0, 0.0, 0.0, 3.0 ] );
4242
* var x = new Float32Array( [ 1.0, 1.0, 1.0 ] );
4343
* var y = new Float32Array( [ 0.0, 0.0, 0.0 ] );
4444
*
4545
* ssymv.ndarray( 'row-major', 'lower', 3, 1.0, A, 3, x, 1, 0, 0.0, y, 1, 0 );
46-
* // y => <Float32Array>[ 6.0, 11.0, 14.0 ]
46+
* // y => <Float32Array>[ 1.0, 2.0, 3.0 ]
4747
*/
4848

4949
// MODULES //

0 commit comments

Comments
 (0)