Skip to content

Add ADR035: User info fetcher CRD changes #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Add ADR035: User info fetcher CRD changes #532

merged 6 commits into from
Jan 25, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jan 22, 2024

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit 2c6746c
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/65b11fbdc4db55000891720c
😎 Deploy Preview https://deploy-preview-532--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

NickLarsenNZ
NickLarsenNZ previously approved these changes Jan 22, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions for changes which you can take or leave :)

Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
@sbernauer
Copy link
Member Author

Thanks a lot @NickLarsenNZ!

NickLarsenNZ
NickLarsenNZ previously approved these changes Jan 23, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit 272f354 Jan 25, 2024
@sbernauer sbernauer deleted the adr-uif branch January 25, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write ADR on CRD changes for UserInfoFetcher
2 participants