Skip to content

Commit d97d181

Browse files
Apply suggestions from code review
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
1 parent 88350d0 commit d97d181

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

modules/contributor/pages/adr/ADR035-user-info-fetcher.adoc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,18 +21,18 @@ We need to design a CRD change for users to enable the UIF.
2121
=== Stand-alone CRD
2222

2323
We could create a new CRD, e.g. UserInfoFetcher and have a controller for it that creates a DaemonSet.
24-
A OpaCluster would than be able to link to a UserInfoFetcher discovery ConfigMap.
24+
An OpaCluster would then be able to link to a UserInfoFetcher discovery ConfigMap.
2525

2626
* Good, because a UIF instance can be shared across multiple OPA clusters -> Simple and improved caching
2727
* Bad, because OPA clusters would need to authenticate against UIF clusters.
2828
* Bad, because UIF might need some form of authorization as well
2929

3030
=== Integrate in OpaCluster
3131

32-
Add a new section to OpaCluster that allows users to spin up a UIF as a sidecar within the Opa DaemonSet.
32+
Add a new section to OpaCluster that allows users to spin up a UIF as a sidecar within the Opa DaemonSet's Pods.
3333

34-
The CRD is mostly copied from the `oidc` AuthenticationClass introduced in xref:adr/ADR032-oidc-support.adoc[] with the addition of needed credentials for Keycloak as well as the admin and user realm and a very simplistic cache.
35-
The cache will be probably extended in the future (e.g. max number of entries or users that should not be cached), which can be done in a non-breaking fashion below `spec.clusterConfig.userInfo.backend.keycloak.cache`.`
34+
The CRD is mostly copied from the `oidc` AuthenticationClass introduced in xref:adr/ADR032-oidc-support.adoc[] with the addition of needed credentials for Keycloak as well as the _admin_ and _user_ realms and a very simplistic cache.
35+
The cache might be extended in the future (e.g. to set the maximum number of cache entries or exempt particular users from being cached), which can be done in a non-breaking fashion below `spec.clusterConfig.userInfo.backend.keycloak.cache`.`
3636

3737
[source,yaml]
3838
----
@@ -72,7 +72,7 @@ stringData:
7272
clientSecret: user-info-fetcher-client-secret
7373
----
7474

75-
* Good, because only accessible via loopback to OPA clusters -> No authentication or authorization needed.
75+
* Good, because only accessible via the loopback network interface to OPA clusters -> No authentication or authorization needed.
7676

7777
== Decision Outcome
7878

0 commit comments

Comments
 (0)