Move navbar into documentation repo #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This depends on stackabletech/documentation-ui#8 for it to actually be respected.
lfrancke
reviewed
Mar 17, 2022
| @@ -0,0 +1 @@ | |||
| ../../node_modules/@antora/lunr-extension/supplemental_ui/js/search-ui.js | |||
There was a problem hiding this comment.
I'm a bit confused. Is this an artifact of the Github PR preview thing or does the file really only contain this single line?
There was a problem hiding this comment.
It's a symlink to that file (which will be installed by npm).
There was a problem hiding this comment.
This is one of those annoying cases where it's called out by the individual file viewer:
and the file browser:
and even the diff browser file tree:
but for some reason it's completely ignored by the diff viewer itself:
lfrancke
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on stackabletech/documentation-ui#8 for it to actually be respected.