Skip to content

Move navbar into a partial, so that the documentation repo can override it #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Mar 15, 2022

No description provided.

@nightkr nightkr self-assigned this Mar 15, 2022
nightkr added a commit to stackabletech/documentation that referenced this pull request Mar 15, 2022
This depends on stackabletech/documentation-ui#8 for it
to actually be respected.
@nightkr nightkr requested a review from a team March 15, 2022 14:38
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe activate branch protection here as well?

@nightkr
Copy link
Member Author

nightkr commented Mar 15, 2022

Good idea.

@nightkr nightkr merged commit 7a73d20 into stackable Mar 15, 2022
@nightkr nightkr deleted the feature/move-navbar branch March 15, 2022 16:08
nightkr added a commit to stackabletech/documentation that referenced this pull request Mar 17, 2022
* Move navbar into documentation repo

This depends on stackabletech/documentation-ui#8 for it
to actually be respected.

* Update ui submodule to current trunk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants