Skip to content

Make timestampdiff return int. #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Conversation

zelch
Copy link
Contributor

@zelch zelch commented Feb 28, 2021

So the mysql timestampdiff documentation does not explicitly declare the
return type, but the documentation heavily implies int.

On the other hand, the MariaDB documentation explicitly specifies it as
int, so we're going to run with int.

Zephaniah E. Loss-Cutler-Hull and others added 2 commits February 28, 2021 14:13
So the mysql timestampdiff documentation does not explicitly declare the
return type, but the documentation heavily implies int.

On the other hand, the MariaDB documentation explicitly specifies it as
int, so we're going to run with int.
@kyleconroy kyleconroy merged commit 98aea27 into sqlc-dev:master Mar 1, 2021
victoraugustolls pushed a commit to Streppel/sqlc that referenced this pull request May 6, 2021
So the mysql timestampdiff documentation does not explicitly declare the
return type, but the documentation heavily implies int.

On the other hand, the MariaDB documentation explicitly specifies it as
int, so we're going to run with int.

Co-authored-by: Zephaniah E. Loss-Cutler-Hull <warp@aehallh.com>
Co-authored-by: Kyle Conroy <kyle@conroy.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants