Skip to content

Commit 98aea27

Browse files
zelchZephaniah E. Loss-Cutler-Hullkyleconroy
authored
Make timestampdiff return int. (#915)
So the mysql timestampdiff documentation does not explicitly declare the return type, but the documentation heavily implies int. On the other hand, the MariaDB documentation explicitly specifies it as int, so we're going to run with int. Co-authored-by: Zephaniah E. Loss-Cutler-Hull <warp@aehallh.com> Co-authored-by: Kyle Conroy <kyle@conroy.org>
1 parent c1db3bb commit 98aea27

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

internal/engine/dolphin/stdlib.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5282,7 +5282,7 @@ func defaultSchema(name string) *catalog.Schema {
52825282
Type: &ast.TypeName{Name: "datetime"},
52835283
},
52845284
},
5285-
ReturnType: &ast.TypeName{Name: "datetime"},
5285+
ReturnType: &ast.TypeName{Name: "int"},
52865286
},
52875287
{
52885288
Name: "TIME_FORMAT",

0 commit comments

Comments
 (0)