Detect nullable fields when having LEFT_JOIN, OUTER_JOIN or RIGHT_JOIN #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any progress to expect on this feature in a near future? Supporting LEFT JOINs is a very demanded feature on our side, I would be happy to help if desired |
|
Any updates on this? Or at least some kind of workaround would be apprciated |
jwilner
pushed a commit
to jwilner/sqlc
that referenced
this pull request
Apr 26, 2021
- Builds on top of sqlc-dev#733 - Properly detects left, right, full joins - Uses proper enum ordering
|
@gwenaskell, @fr3fou I've updated the good work here and have handled a few more cases in this PR |
jwilner
pushed a commit
to jwilner/sqlc
that referenced
this pull request
Apr 26, 2021
- Builds on top of sqlc-dev#733 - Properly detects left, right, full joins - Uses proper enum ordering
jwilner
pushed a commit
to jwilner/sqlc
that referenced
this pull request
Apr 26, 2021
- Builds on top of sqlc-dev#733 - Properly detects left, right, full joins - Uses proper enum ordering
|
Closing in favor of #983 |
kyleconroy
pushed a commit
that referenced
this pull request
May 7, 2021
- Builds on top of #733 - Properly detects left, right, full joins - Uses proper enum ordering Co-authored-by: Ryad El-Dajani <ryad.eldajani@posteo.de>
eliteprodev
pushed a commit
to eliteprodev/safesql_generator
that referenced
this pull request
May 17, 2023
- Builds on top of sqlc-dev/sqlc#733 - Properly detects left, right, full joins - Uses proper enum ordering Co-authored-by: Ryad El-Dajani <ryad.eldajani@posteo.de>
eliteprodev
added a commit
to eliteprodev/safesql_generator
that referenced
this pull request
Jun 26, 2023
- Builds on top of sqlc-dev/sqlc#733 - Properly detects left, right, full joins - Uses proper enum ordering Co-authored-by: Ryad El-Dajani <ryad.eldajani@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects nullable fields when executing nullable joins LEFT_JOIN, OUTER_JOIN or RIGHT_JOIN.
I'm not sure though, if the implementation is consistent nor on the right layer in the application. I think, this is a lower layer issue that has to be detected and/or fixed in pg_query parser but I might be wrong.
Edit: Test "booktest" is currently failing since BooksByTagsRow.Name should be sql.NullString in the first place (since Name is a field from authors fetched by left join).
Fixes Issues: #374 #604