Support for nullable fields in joins #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jwilner
commented
Apr 26, 2021
jwilner
commented
- Builds on top of Detect nullable fields when having LEFT_JOIN, OUTER_JOIN or RIGHT_JOIN #733
- Properly detects left, right, full joins
- Uses proper enum ordering
- Builds on top of sqlc-dev#733 - Properly detects left, right, full joins - Uses proper enum ordering
|
@kyleconroy can we please enable CI for this PR? This issue is a major blocker for adoption for at least some of us. |
|
@jwilner CI has been enabled. I really hate that GitHub turned off actions for first time contributors. |
kyleconroy
approved these changes
May 6, 2021
|
Thanks @kyleconroy! Merged in main. RE blocking CI for first time contributors, it kind of makes sense to me -- like a month ago I saw some malicious GH accounts open up thousands of PRs on https://github.com/golangci/golangci-lint to mine crypto with the CI. I assume blocking the CI is intended to deter that! |
|
This is awesome, can't wait for the next release, great work! |
|
When is the next release getting published? |
|
Super excited for the next release! Thanks @jwilner and @kyleconroy for all your hard work 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.